You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by sandeep samudrala <sa...@gmail.com> on 2015/09/25 09:02:20 UTC
Review Request 38759: Flaky
EntityManagerJerseyIT#testDuplicateSubmitCommands
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38759/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1469
https://issues.apache.org/jira/browse/FALCON-1469
Repository: falcon-git
Description
-------
testDuplicateSubmitCommands(org.apache.falcon.resource.EntityManagerJerseyIT) fails sometimes as during submission , it deletes any exisiting directory(staging) from hdfs. Removed that part in case of parallel submission test.
Diffs
-----
webapp/src/test/java/org/apache/falcon/resource/TestContext.java d067dee
webapp/src/test/java/org/apache/falcon/validation/ClusterEntityValidationIT.java 402381d
Diff: https://reviews.apache.org/r/38759/diff/
Testing
-------
Thanks,
sandeep samudrala
Re: Review Request 38759: Flaky
EntityManagerJerseyIT#testDuplicateSubmitCommands
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38759/#review100648
-----------------------------------------------------------
Ship it!
Ship It!
- Balu Vellanki
On Sept. 25, 2015, 7:02 a.m., sandeep samudrala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38759/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 7:02 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1469
> https://issues.apache.org/jira/browse/FALCON-1469
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> testDuplicateSubmitCommands(org.apache.falcon.resource.EntityManagerJerseyIT) fails sometimes as during submission , it deletes any exisiting directory(staging) from hdfs. Removed that part in case of parallel submission test.
>
>
> Diffs
> -----
>
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java d067dee
> webapp/src/test/java/org/apache/falcon/validation/ClusterEntityValidationIT.java 402381d
>
> Diff: https://reviews.apache.org/r/38759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> sandeep samudrala
>
>
Re: Review Request 38759: Flaky
EntityManagerJerseyIT#testDuplicateSubmitCommands
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38759/#review100959
-----------------------------------------------------------
Ship it!
Ship It!
- Pallavi Rao
On Sept. 29, 2015, 12:29 p.m., sandeep samudrala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38759/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 12:29 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1469
> https://issues.apache.org/jira/browse/FALCON-1469
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> testDuplicateSubmitCommands(org.apache.falcon.resource.EntityManagerJerseyIT) fails sometimes as during submission , it deletes any exisiting directory(staging) from hdfs. Removed that part in case of parallel submission test.
>
>
> Diffs
> -----
>
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 384c8a0
>
> Diff: https://reviews.apache.org/r/38759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> sandeep samudrala
>
>
Re: Review Request 38759: Flaky
EntityManagerJerseyIT#testDuplicateSubmitCommands
Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38759/
-----------------------------------------------------------
(Updated Sept. 29, 2015, 12:29 p.m.)
Review request for Falcon.
Bugs: FALCON-1469
https://issues.apache.org/jira/browse/FALCON-1469
Repository: falcon-git
Description
-------
testDuplicateSubmitCommands(org.apache.falcon.resource.EntityManagerJerseyIT) fails sometimes as during submission , it deletes any exisiting directory(staging) from hdfs. Removed that part in case of parallel submission test.
Diffs (updated)
-----
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 384c8a0
Diff: https://reviews.apache.org/r/38759/diff/
Testing
-------
Thanks,
sandeep samudrala
Re: Review Request 38759: Flaky
EntityManagerJerseyIT#testDuplicateSubmitCommands
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38759/#review100952
-----------------------------------------------------------
webapp/src/test/java/org/apache/falcon/resource/TestContext.java (line 355)
<https://reviews.apache.org/r/38759/#comment158238>
I think the fix won't work if you do not remove deleteClusterLocations because there is still a possiblity that the locations get deleted when a submit is happening in parallel. Since createClusterLocations deletes and recreates the staging and working paths, that alone should be sufficient.
- Pallavi Rao
On Sept. 25, 2015, 7:02 a.m., sandeep samudrala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38759/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 7:02 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1469
> https://issues.apache.org/jira/browse/FALCON-1469
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> testDuplicateSubmitCommands(org.apache.falcon.resource.EntityManagerJerseyIT) fails sometimes as during submission , it deletes any exisiting directory(staging) from hdfs. Removed that part in case of parallel submission test.
>
>
> Diffs
> -----
>
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java d067dee
> webapp/src/test/java/org/apache/falcon/validation/ClusterEntityValidationIT.java 402381d
>
> Diff: https://reviews.apache.org/r/38759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> sandeep samudrala
>
>
Re: Review Request 38759: Flaky
EntityManagerJerseyIT#testDuplicateSubmitCommands
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38759/#review100837
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Sept. 25, 2015, 7:02 a.m., sandeep samudrala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38759/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 7:02 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1469
> https://issues.apache.org/jira/browse/FALCON-1469
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> testDuplicateSubmitCommands(org.apache.falcon.resource.EntityManagerJerseyIT) fails sometimes as during submission , it deletes any exisiting directory(staging) from hdfs. Removed that part in case of parallel submission test.
>
>
> Diffs
> -----
>
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java d067dee
> webapp/src/test/java/org/apache/falcon/validation/ClusterEntityValidationIT.java 402381d
>
> Diff: https://reviews.apache.org/r/38759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> sandeep samudrala
>
>