You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2013/01/07 15:04:12 UTC

[jira] [Resolved] (WICKET-4939) AbstractAjaxTimerBehavior never triggers if attached to WebPage

     [ https://issues.apache.org/jira/browse/WICKET-4939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-4939.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 6.5.0
         Assignee: Martin Grigorov
    
> AbstractAjaxTimerBehavior never triggers if attached to WebPage
> ---------------------------------------------------------------
>
>                 Key: WICKET-4939
>                 URL: https://issues.apache.org/jira/browse/WICKET-4939
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.4.0
>            Reporter: Jonas
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 6.5.0
>
>
> Since WICKET-4886 was fixed, AbstractAjaxTimerBehavior never triggers anymore if it is added the the page itself.
> See: org.apache.wicket.ajax.AbstractAjaxTimerBehavior.shouldTrigger()
> getComponent().findParent(WebPage.class) != null
> is always false in that case, which seems to be wrong. It should also be ok if the component itself is the WebPage.
> So, the method should probably read something like
> 	private boolean shouldTrigger()
> 	{
> 		return isStopped() == false &&
> 				isEnabled(getComponent()) &&
> 				(getComponent().findParent(WebPage.class) != null || getComponent() instanceof WebPage);
> 	}
> Temporary workaround:
> add the AbstractAjaxTimerBehavior to a subcomponent of the page instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira