You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/21 11:01:34 UTC
[GitHub] [spark] LuciferYang opened a new pull request #35597: [SPARK-38274][BUILD] Upgarde junit4 to 4.13.2 and upgrade corresponding junit-interface to 0.13.3
LuciferYang opened a new pull request #35597:
URL: https://github.com/apache/spark/pull/35597
### What changes were proposed in this pull request?
The main change of this pr as follows:
- Upgarde `junit4` to `4.13.2`: https://github.com/junit-team/junit4/blob/HEAD/doc/ReleaseNotes4.13.2.md
- Change `junit-interface` groupId from `com.novocode` to `com.github.sbt` due to the organization name has changed to "com.github.sbt" in 0.12 and upgrade `junit-interface` version to `0.13.3` refer to [https://github.com/sbt/junit-interface/#setup](https://github.com/sbt/junit-interface/#setup)
### Why are the changes needed?
Upgarde test framework.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35597: [SPARK-38274][BUILD] Upgarde `JUnit4` to `4.13.2` and upgrade corresponding `junit-interface` to `0.13.3`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35597:
URL: https://github.com/apache/spark/pull/35597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35597: [SPARK-38274][BUILD] Upgarde `junit4` to `4.13.2` and upgrade corresponding `junit-interface` to `0.13.3`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35597:
URL: https://github.com/apache/spark/pull/35597#issuecomment-1046751685
cc @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #35597: [SPARK-38274][BUILD] Upgarde `JUnit4` to `4.13.2` and upgrade corresponding `junit-interface` to `0.13.3`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #35597:
URL: https://github.com/apache/spark/pull/35597#discussion_r811516616
##########
File path: pom.xml
##########
@@ -1144,9 +1144,9 @@
<scope>test</scope>
</dependency>
<dependency>
- <groupId>com.novocode</groupId>
+ <groupId>com.github.sbt</groupId>
<artifactId>junit-interface</artifactId>
- <version>0.11</version>
+ <version>0.13.3</version>
Review comment:
ok ~ I'll try to promote the update of setup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #35597: [SPARK-38274][BUILD] Upgarde `JUnit4` to `4.13.2` and upgrade corresponding `junit-interface` to `0.13.3`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #35597:
URL: https://github.com/apache/spark/pull/35597#discussion_r811516616
##########
File path: pom.xml
##########
@@ -1144,9 +1144,9 @@
<scope>test</scope>
</dependency>
<dependency>
- <groupId>com.novocode</groupId>
+ <groupId>com.github.sbt</groupId>
<artifactId>junit-interface</artifactId>
- <version>0.11</version>
+ <version>0.13.3</version>
Review comment:
ok ~ I'll try to promote the update of the setup guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35597: [SPARK-38274][BUILD] Upgarde `JUnit4` to `4.13.2` and upgrade corresponding `junit-interface` to `0.13.3`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35597:
URL: https://github.com/apache/spark/pull/35597#discussion_r811463914
##########
File path: pom.xml
##########
@@ -1144,9 +1144,9 @@
<scope>test</scope>
</dependency>
<dependency>
- <groupId>com.novocode</groupId>
+ <groupId>com.github.sbt</groupId>
<artifactId>junit-interface</artifactId>
- <version>0.11</version>
+ <version>0.13.3</version>
Review comment:
It seems that the setup guide is outdated because it still points to `0.13.2`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35597: [SPARK-38274][BUILD] Upgarde `JUnit4` to `4.13.2` and upgrade corresponding `junit-interface` to `0.13.3`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35597:
URL: https://github.com/apache/spark/pull/35597#issuecomment-1046814886
Copy comparison between `JUnit` and `junit-interface` from [https://github.com/sbt/junit-interface/](https://github.com/sbt/junit-interface/#setup) as follows:
junit-interface version | JUnit version
:-------------------------|:--------------
0.13.2 | 4.13.2
0.13.1 | 4.13.1
0.13 | 4.13
0.12 | 4.12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35597: [SPARK-38274][BUILD] Upgarde `JUnit4` to `4.13.2` and upgrade corresponding `junit-interface` to `0.13.3`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35597:
URL: https://github.com/apache/spark/pull/35597#issuecomment-1047349954
thanks all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org