You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "V.Narayanan (JIRA)" <ji...@apache.org> on 2007/07/19 13:16:04 UTC
[jira] Created: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Add commands to NetworkServerControl for interacting with the replication functionality
---------------------------------------------------------------------------------------
Key: DERBY-2954
URL: https://issues.apache.org/jira/browse/DERBY-2954
Project: Derby
Issue Type: Sub-task
Reporter: V.Narayanan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523207 ]
Øystein Grøvlen commented on DERBY-2954:
----------------------------------------
I have looked at the patch it looks good. I think my major comment is
more about the way NetworkServerControlImpl is implemented, and I do
not expect this to be fixed by this patch. It seems that dashed
arguments that are allowed for one command, is accepted by all
commands. This problem becomes more evident now since several new
arguments are introduced that does only apply to the replication
commands. Originally, I think all commands had the same set of
arguments, but earlier 'trace' got a -s argument and 'start' the
-noSecurityManager argument. Hence, this is not the first patch that
has this problem. However, this patch creates some new issues that
needs to be considered:
1. If I give a non-int argument value to -slaveport, the command is
silently ignored without any error message (e.g., 'shutdown
-slaveport x' does not shut down the server, and 'startmaster
-slaveport x' does not cause the 'not implemented' message to be
printed).
2. The empty string is accepted as a command.
'java -jar jars/sane/derbyrun.jar server ""' returns without error.
Other comments:
3. I suggest to call the command 'failover' not 'startfailover' since
this is an action, not a process that will continue until it is
stopped by another command.
4. I am starting to think that 'startreplication' may be a better name
than 'startmaster'. That will give similar names for starting and
stopping replication.
5. I think a comment is needed to explain the presence of the empty
string in the COMMANDS array.
6. I do not think the synchronization in setReplicationDB is needed.
The client is not going to be multi-threaded. It is the server
part of the code that needs synchronization. (I think it has been
discussed to split this class to have separate classes for client
and server code to make this clearer.)
7. I think the text of the DRDA_Slaveurl.I message should use the term
'host' instead of 'url' since that is the term used by the usage
message.
8. I suggest to change the usage text for the arguments of -slavehost
and -slaveport to '<host>' and '<portnumber>'.
9. I would think all the new commands will allow the -p, -h, and -ssl
arguments also, and the usage message should be updated to reflect
that.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-2954:
-------------------------------
Attachment: NetworkServerControlCmds_v5.stat
NetworkServerControlCmds_v5.diff
I am really sorry for the failures during the deryall run. They were
due to the additional output regarding the new commands
introduced in NetworkServerControl related to replication.
I have fixed the issues in this patch.
I am currently running the tests and shall revert back with
the results as soon as the tests finish.
My apologies for the earlier failures once again
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525065 ]
V.Narayanan commented on DERBY-2954:
------------------------------------
I have run the junit suite and saw no failures. If everything is OK I request for this
patch to be considered for a commit.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-2954:
-------------------------------
Attachment: NetworkServerControlCmds_v4.stat
NetworkServerControlCmds_v4.diff
Thank you for the reviews and comments Oystein.
I have fixed the indentation with a few spaces to
align the arguments. I am hoping that this is OK.
Since in this patch I have removed one attribute
and fixed an indentation I have not run tests.
I request for this patch to be considered for a commit.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Øystein Grøvlen updated DERBY-2954:
-----------------------------------
Derby Info: (was: [Patch Available])
Reverted patch v5 since NetworkServerControlImpl will not support commands for replication. (revision 635920)
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Components: Miscellaneous
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat, NetworkServerControlCmds_v6.diff, NetworkServerControlCmds_v6.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514208 ]
V.Narayanan commented on DERBY-2954:
------------------------------------
I agree that it makes more sense to have the API as
separate commands like startmaster, startslave, failover,
stopreplication.
I agree that this conforms more with the existing scenario.
I shall take cognizance of the comments made and shall
redesign the functional spec apropos.
I hope to put in a new functional spec by Monday
Thanks a ton for the comments
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan reassigned DERBY-2954:
----------------------------------
Assignee: V.Narayanan
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Reporter: V.Narayanan
> Assignee: V.Narayanan
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "John H. Embretsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586299#action_12586299 ]
John H. Embretsen commented on DERBY-2954:
------------------------------------------
Wouldn't a resolution of "Later" or "Won't Fix" have been better suited to this issue than "Fixed", since the commands have not actually been added?
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Components: Miscellaneous
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.4.0.0
>
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat, NetworkServerControlCmds_v6.diff, NetworkServerControlCmds_v6.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523832 ]
V.Narayanan commented on DERBY-2954:
------------------------------------
I ran tests on v3 of this patch and the I had no failures.
If everything is OK I request for v3 to be considered for a commit.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513880 ]
V.Narayanan commented on DERBY-2954:
------------------------------------
All user interaction with the replication functionality
will be through commands to NetworkServerControl.
The following commands will be supported.
Start Master
java org.apache.derby.drda.NetworkServerControl replication -startmaster -db=<dbname> -url=<slaveurl:port>
Start Slave
java org.apache.derby.drda.NetworkServerControl replication -startslave -db=<dbname> -port=<port>
Failover (slave only)
java org.apache.derby.drda.NetworkServerControl replication -failover -db=<dbname>
Stop Replication (master only)
java org.apache.derby.drda.NetworkServerControl replication -stop -db=<dbname>
The start and failover commands are restricted to the same machine that the database
resides. Hence, master commands are restricted to the machine that has the master
database, while slave commands are restricted to the machine that has the slave database.
The stop replication command can only be issued on the master. The master will in turn
send a stop replication message to the slave.
Authorization and Authentication
The commands above apply only to the database specified, and only the database owner
will be authorized to execute them. This implies that authentication is required.
Authentication will follow the same strategy as authentication for other NetworkServerControl
commands. Specifically, the approach that will be chosen for DERBY-2109 will be used for
replication as well.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Reporter: V.Narayanan
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan resolved DERBY-2954.
--------------------------------
Resolution: Fixed
Fix Version/s: 10.4.0.0
"NetworkServerControlImpl will not support commands for replication."
Resolving issue since all patches relevant to this have been submitted or
committed.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Components: Miscellaneous
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.4.0.0
>
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat, NetworkServerControlCmds_v6.diff, NetworkServerControlCmds_v6.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jørgen Løland updated DERBY-2954:
---------------------------------
Derby Info: [Patch Available]
Setting patch available since patch v5 needs to be reverted for now (10.4 release)
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Components: Miscellaneous
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat, NetworkServerControlCmds_v6.diff, NetworkServerControlCmds_v6.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514196 ]
Øystein Grøvlen commented on DERBY-2954:
----------------------------------------
I have a few comments to the syntax chosen for the
NetworkServerControl commands. I think it is important that the new
commands are well aligned with existing commands in order to give a
uniform and consistent view.
1. I see that you have chosen to have single replication commands with
subcommands for the different replication operations. An
alternative would be to have different top level commands
(e.g., startmaster, startslave, failover, stopreplication). Do you
have a rationale for your decision? I am not quite sure what is
best choice.
2. If you stick with the two level commands, I think you should not
use '-' in front of the sub level commands. I think these should
be viewed as commands, not options. If you look at existing
commands, the main arguments are usually not handled as options.
(e.g., logconnections, maxthreads, timeslice, trace)
3. Syntax for options: The use of '=' is different from the existing
syntax.
4. All existing commands have the [-h <host>][-p <portnumber>]. I
think you could also use those instead of your proposed -url and
-port options.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-2954:
-------------------------------
Attachment: NetworkServerControlCmds_v3.stat
NetworkServerControlCmds_v3.diff
Thank you for the reviews and comments Oystein
v3 addresses all the issues pointed out in v2 of the patch
I addressed 1) by catching the NumberFormatException
that is thrown upon parsing for an integer in a String
containing an unexpected alpha-numeric along the same
lines of what happens currently for -h and -p dashed arguments.
I addressed 2) by adding a check in the findCommands
method that parses the arguments passed to
NetworkServerControl class to ensure that the length of
the command passed in greater than 0.
I have addressed all the other issues pointed out also.
I have not yet run tests on this patch and shall post
the results of the test run tomorrow.
I request for this patch to be considered for comments and reviews.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521764 ]
V.Narayanan commented on DERBY-2954:
------------------------------------
I ran tests on this patch and found no failures. I request for this patch to be considered for a commit.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-2954:
-------------------------------
Attachment: NetworkServerControlCmds_v2.stat
NetworkServerControlCmds_v2.diff
Thank you for reviewing this patch. Your comment is very valid.
In this patch I have modified the replication commands to print
"Replication Not Implemented Yet".
I have however made each command parsing point to print this
so that in the future when I implement the commands I can
incrementally put in the implementations while the other
commands can still print this message.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Øystein Grøvlen updated DERBY-2954:
-----------------------------------
Derby Info: (was: [Patch Available])
Committed patch NetworkServerControlCmds_v5.diff
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514206 ]
Øystein Grøvlen commented on DERBY-2954:
----------------------------------------
Øystein Grøvlen (JIRA) wrote:
> 4. All existing commands have the [-h <host>][-p <portnumber>]. I
> think you could also use those instead of your proposed -url and
> -port options.
I was wrong here. -h/-p is of course needed to specify the address to
contact the server on, and cannot be used to to specify other hosts or
ports. Still, I recommend that you make the commands more uniform by
using the same types for both startmaster and startslave. Either, a
url for both or host/port separately for both. Make sure that it is
easy to distinguish these new options from the existing ones. Maybe
"slave" should be part of the name for these options.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-2954:
-------------------------------
Affects Version/s: 10.4.0.0
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563898#action_12563898 ]
Jørgen Løland commented on DERBY-2954:
--------------------------------------
As stated in the func spec on DERBY-2872, NetworkServerControl commands will not be included in the 10.4 release. For this release, we will only have connection properties. Hence, the committed patch (v5) on this issue should be reverted. v6 seems to never have been committed.
I reverted the patch locally and ran all tests without errors.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Components: Miscellaneous
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat, NetworkServerControlCmds_v6.diff, NetworkServerControlCmds_v6.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jørgen Løland updated DERBY-2954:
---------------------------------
Derby Info: [Patch Available]
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Components: Miscellaneous
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat, NetworkServerControlCmds_v6.diff, NetworkServerControlCmds_v6.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524635 ]
Øystein Grøvlen commented on DERBY-2954:
----------------------------------------
When I run derbyall, the following tests fail due to changes in the usage output:
derbyall/derbynetmats/derbynetmats.fail:derbynet/maxthreads.java
derbyall/derbynetmats/derbynetmats.fail:derbynet/testProperties.java
derbyall/derbynetmats/derbynetmats.fail:derbynet/timeslice.java
derbyall/derbyall.fail:tools/derbyrunjartest.java
derbyall/derbynetclientmats/derbynetmats.fail:derbynet/maxthreads.java
derbyall/derbynetclientmats/derbynetmats.fail:derbynet/testProperties.java
derbyall/derbynetclientmats/derbynetmats.fail:derbynet/timeslice.java
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "John H. Embretsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John H. Embretsen reopened DERBY-2954:
--------------------------------------
Reopening to adjust resolution status.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Components: Miscellaneous
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.4.0.0
>
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat, NetworkServerControlCmds_v6.diff, NetworkServerControlCmds_v6.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525005 ]
V.Narayanan commented on DERBY-2954:
------------------------------------
I ran the following command
nohup java org.apache.derbyTesting.functionTests.harness.RunSuite derbyall &
I got the following
290 Tests Run
100% Pass (290 tests passed)
0% Fail (0 tests failed)
0 Suites skipped
in derbyall_report.txt
I am running the junit suite also and shall revert with the results as soon as the tests finish
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586301#action_12586301 ]
V.Narayanan commented on DERBY-2954:
------------------------------------
This JIRA issues has caused changes to the codebase in the form of code that has first been
committed and then been reverted. I decided to stick to fixed because there has been code
changes as a result of this JIRA (although they have been reverted).
Pls do go ahead and change it to "not fixed" if you think that is the right thing here.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Components: Miscellaneous
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.4.0.0
>
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat, NetworkServerControlCmds_v6.diff, NetworkServerControlCmds_v6.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514156 ]
V.Narayanan commented on DERBY-2954:
------------------------------------
I have started work on the fail-over command.
As a first step I was looking at how to introduce this new command
in the NetworkServerControl class.
I envisaged the following steps and started working on this issue.
1) Add a entry for the replication base command in the COMMANDS String array.
2) Add the integer translation for the command as COMMAND_REPLICATION and assign
it the value of 11.
3) Catch this in executeWork() and call the failover handler(does not exist yet)
Simple as the series of steps seem I ran into complications due to the following
reasons
As I understand the process of command translation the findCommands
method returns the integer representation of the command that is entered.
This method basically returns the index of the COMMANDS array at which the
string for the command is found.
All was well until I tried to give the replication command a value of 11
and followed the modifications steps listed above.
I realized that 10 was a command that was not present in the COMMAND array.
It refers to COMMAND_PROPERTIES which refers to the command the network
server receives from the client.
This seems to be a hard-coded value which I could not modify by tweaking
COMMAND_PROPERTIES = 11 and
COMMAND_REPLICATION = 10.
1) I see the simplest way of fixing this as being replacing the 10th index in the
array to be an empty String "" and starting replication commands from index 11.
In this way even if you pass an empty string a command expected message would be
thrown without any other tweaks.
2) Another way would be replcation the 10 index with the INVALID command and mapping
this INVALID command to -1 which refers to COMMAND_UNKNOWN and the starting the
replication commands from the 11th index.
I like 1 better and am going to go ahead and handle this issue this way unless I
receive any objection from the community.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (DERBY-2954) Add commands to
NetworkServerControl for interacting with the replication functionality
Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542764 ]
jorgenlo edited comment on DERBY-2954 at 11/15/07 4:55 AM:
----------------------------------------------------------------
Since the functional spec for replication has changed with respect to how the replication commands are issued (now using connection url), the CLI commands should use the connection url method internally instead of a separate implementation. Linking this issue to the connection url jiras. Latest func spec can be found on DERBY-2872.
was (Author: jorgenlo):
Since the functional spec has changed with respect to how the replication commands are issued (now using connection url), the CLI commands should use the connection url method internally instead of a separate implementation. Linking this issue to the connection url jiras.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Components: Miscellaneous
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat, NetworkServerControlCmds_v6.diff, NetworkServerControlCmds_v6.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522494 ]
Jørgen Løland commented on DERBY-2954:
--------------------------------------
Hi Narayanan,
I reviewed the patch, and I think it looks good. I have one question, though: Since this patch adds a command that a user can issue but does not do anything, would it be good to print something like "Replication not implemented yet" to the console? You could for instance add one more console property message that is called from the setReplicationDB method.
I am not sure if printing this message is necessary since the functionality will be added before a new release is made - just a thought.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-2954:
-------------------------------
Derby Info: [Patch Available]
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-2954:
-------------------------------
Attachment: NetworkServerControlCmds_v6.stat
NetworkServerControlCmds_v6.diff
The following patch propogates the commands parsed in NetworkServerControlImpl to the controllers (Master and slave controllers). The patch does not add any functionality for the commands as such but only takes care of propogating the commands to the controllers.
The following four replication related commands are handled in this patch.
1) startmaster
2) startslave
3) startfailover
4) stopreplication
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat, NetworkServerControlCmds_v6.diff, NetworkServerControlCmds_v6.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523827 ]
Øystein Grøvlen commented on DERBY-2954:
----------------------------------------
Thank you for addressing my comments Narayanan. The patch looks very
good. I have tested that it fixes the issues I raised. I have only some minor nits:
1. replicationdbSync can be removed since it is no longer used.
2. The indentation and the way the if statement is broken into lines
makes the new code in findCommand() a bit hard to read.
I suggest you indent the wrapped lines of the if statement, and put each argument
on a separate line.
If nobody beats me to it, I will commit this patch when I get the
necessary powers to do so.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "Mike Matrigali (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Matrigali updated DERBY-2954:
----------------------------------
Component/s: Miscellaneous
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Components: Miscellaneous
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat, NetworkServerControlCmds_v6.diff, NetworkServerControlCmds_v6.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-2954:
-------------------------------
Attachment: NetworkServerControlCmds_v1.stat
NetworkServerControlCmds_v1.diff
Pls find attached a preliminary patch that adds the following commands to NetworkServerControl.
1) startmaster
2) startslave
3) startfailover
4) startreplication
The logic for performing appropriate actions in the replication context
is not added as yet. This patch just adds the commands to NetworkServerControl.
After applying the patch calling these commands will not do anything. However internally the parameters that are passed will be parsed and initialized.
I have made one small deviation from the functional spec.
The replication database name was earlier a dashed argument. I have changed it to be part of the command here.
For example
java org.apache.derby.drda.NetworkServerControl startmaster
-db <dbname> -slavehost <slavehost> -slaveport <slaveport>
will now be
java org.apache.derby.drda.NetworkServerControl startmaster <dbname>
-slavehost <slavehost> -slaveport <slaveport>
the dbname being a compulsory part of the command.
I derived this from the format of the tracedirectory and the logConnections commands where the parameters are not
dashed arguments but instead are a part of the command.
Pls note that I have not run tests on this patch yet.
This patch is not for a commit.
Pls consider this patch for reviews and comments.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "Dyre Tjeldvoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dyre Tjeldvoll updated DERBY-2954:
----------------------------------
Derby Info: (was: [Patch Available])
Seems like all available patches have been committed, so I'm unchecking 'Patch available'. Don't know if the issue can be closed/resolved yet...
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Components: Miscellaneous
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat, NetworkServerControlCmds_v6.diff, NetworkServerControlCmds_v6.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2954) Add commands to NetworkServerControl
for interacting with the replication functionality
Posted by "John H. Embretsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John H. Embretsen resolved DERBY-2954.
--------------------------------------
Resolution: Won't Fix
Resolving as "Won't fix", since the intended changes were first added, then removed from the repository. This way there is less chance that users browsing Jira will get the wrong impression, and it will be more clear if someone decides to actually add the commands later.
Relevant history as I know it:
Code changes were applied to trunk with revision 572944, and were reverted from trunk with revision 635920 (and partly revision 617168 (DERBY-3088); test conversion). Remaining changes were reverted from 10.4 branch with revision 636369.
> Add commands to NetworkServerControl for interacting with the replication functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Components: Miscellaneous
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.4.0.0
>
> Attachments: NetworkServerControlCmds_v1.diff, NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff, NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff, NetworkServerControlCmds_v3.stat, NetworkServerControlCmds_v4.diff, NetworkServerControlCmds_v4.stat, NetworkServerControlCmds_v5.diff, NetworkServerControlCmds_v5.stat, NetworkServerControlCmds_v6.diff, NetworkServerControlCmds_v6.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.