You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Danny Chen (Jira)" <ji...@apache.org> on 2020/04/07 11:36:00 UTC

[jira] [Resolved] (CALCITE-3892) Make junit test classes and methods non-public

     [ https://issues.apache.org/jira/browse/CALCITE-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Danny Chen resolved CALCITE-3892.
---------------------------------
    Resolution: Fixed

Fixed in [9492dd4|https://github.com/apache/calcite/commit/9492dd4146f63ddc028010d6c4e86f6a5cb29a8d] !

> Make junit test classes and methods non-public
> ----------------------------------------------
>
>                 Key: CALCITE-3892
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3892
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>            Priority: Major
>             Fix For: 1.23.0
>
>
> In junit 4 and earlier versions, junit classes and methods must be public. In junit 5 (jupiter) this is no longer the case.
> This change makes classes and methods package-protected where possible (i.e. removes the "public" modifier). It makes tests a bit more concise, and gives us more freedom to refactor tests in future.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)