You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "reschke (via GitHub)" <gi...@apache.org> on 2023/09/04 14:21:46 UTC
[GitHub] [sling-org-apache-sling-resourceresolver] reschke opened a new pull request, #99: SLING-12018: resource resolver: add metrics for resources with sling:alias/vanityPath found on startup
reschke opened a new pull request, #99:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/99
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] joerghoh commented on a diff in pull request #99: SLING-12018: resource resolver: add metrics for resources with sling:alias/vanityPath found on startup
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh commented on code in PR #99:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/99#discussion_r1315014292
##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -1407,15 +1417,17 @@ private Map<String, List<String>> loadVanityPaths(ResourceResolver resolver) {
}
}
long processElapsed = System.nanoTime() - processStart;
- log.debug("processed {} vanityPaths (of which {} in scope) in {}ms", count, countInScope, TimeUnit.NANOSECONDS.toMillis(processElapsed));
+ log.debug("processed {} resources with sling:vanityPath properties (of which {} in scope) in {}ms", count, countInScope, TimeUnit.NANOSECONDS.toMillis(processElapsed));
if (!isAllVanityPathEntriesCached()) {
if (countInScope > this.factory.getMaxCachedVanityPathEntries()) {
- log.warn("Number of vanity paths in scope ({}) exceeds configured cache size ({}); handling of uncached vanity paths will be much slower. Consider increasing the cache size or decreasing the number of vanity paths.", countInScope, this.factory.getMaxCachedVanityPathEntries());
+ log.warn("Number of resources with sling:vanityPath properties ({}) exceeds configured cache size ({}); handling of uncached vanity paths will be much slower. Consider increasing the cache size or decreasing the number of vanity paths.", countInScope, this.factory.getMaxCachedVanityPathEntries());
} else if (countInScope > (this.factory.getMaxCachedVanityPathEntries() / 10) * 9) {
- log.info("Number of vanity paths in scope ({}) within 10% of configured cache size ({})", countInScope, this.factory.getMaxCachedVanityPathEntries());
+ log.info("Number of resources with sling:vanityPath properties in scope ({}) within 10% of configured cache size ({})", countInScope, this.factory.getMaxCachedVanityPathEntries());
Review Comment:
```suggestion
log.info("Number of resources with sling:vanityPath property in scope ({}) within 10% of configured cache size ({})", countInScope, this.factory.getMaxCachedVanityPathEntries());
```
##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -1407,15 +1417,17 @@ private Map<String, List<String>> loadVanityPaths(ResourceResolver resolver) {
}
}
long processElapsed = System.nanoTime() - processStart;
- log.debug("processed {} vanityPaths (of which {} in scope) in {}ms", count, countInScope, TimeUnit.NANOSECONDS.toMillis(processElapsed));
+ log.debug("processed {} resources with sling:vanityPath properties (of which {} in scope) in {}ms", count, countInScope, TimeUnit.NANOSECONDS.toMillis(processElapsed));
if (!isAllVanityPathEntriesCached()) {
if (countInScope > this.factory.getMaxCachedVanityPathEntries()) {
- log.warn("Number of vanity paths in scope ({}) exceeds configured cache size ({}); handling of uncached vanity paths will be much slower. Consider increasing the cache size or decreasing the number of vanity paths.", countInScope, this.factory.getMaxCachedVanityPathEntries());
+ log.warn("Number of resources with sling:vanityPath properties ({}) exceeds configured cache size ({}); handling of uncached vanity paths will be much slower. Consider increasing the cache size or decreasing the number of vanity paths.", countInScope, this.factory.getMaxCachedVanityPathEntries());
Review Comment:
```suggestion
log.warn("Number of resources with sling:vanityPath property ({}) exceeds configured cache size ({}); handling of uncached vanity paths will be much slower. Consider increasing the cache size or decreasing the number of vanity paths.", countInScope, this.factory.getMaxCachedVanityPathEntries());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] reschke merged pull request #99: SLING-12018: resource resolver: add metrics for resources with sling:alias/vanityPath found on startup
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke merged PR #99:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org