[jira] Commented: (FTPSERVER-357) Implement IP Filtering based on black or white list

["Sai Pullabhotla (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853427#action_12853427 ] 

Sai Pullabhotla commented on FTPSERVER-357:
-------------------------------------------

I'm wondering if we need to change the signature on the IpFilter interface. 

Currently, it requires that - boolean accept(InetAddress address) method be implemented. 

While this does the job pretty good, It does not give any information about the local network interface to which the client attempted to connect. This could be important for some people for the following reasons: 

1. Auditing - simply log the remote client's IP, port and local interface IP and port. 
2. If some one wants to implement a filter based on the both remote and local IPs. For example, allow client X to connect on interface A, but not on B and C. 

If you agree with me on this, the IpFilter interface probably needs to have the below method instead of the current one: 

boolean accept(SocketAddress remoteAddress, SocketAddress localAddress)

Your ideas and thoughts are appreciated. 

> Implement IP Filtering based on black or white list
> ---------------------------------------------------
>
>                 Key: FTPSERVER-357
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-357
>             Project: FtpServer
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Sai Pullabhotla
>             Fix For: 1.1.0
>
>         Attachments: ftpserver-ipfilter.patch, ftpserver-ipfilter2.patch
>
>
> Create a new IP Filter based on black or white list to deny or allow incoming client connections. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.