You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tkalkirill (via GitHub)" <gi...@apache.org> on 2025/10/16 07:17:20 UTC
[PR] IGNITE-26725 Add logging of fsync files for aipersist [ignite-3]
tkalkirill opened a new pull request, #6790:
URL: https://github.com/apache/ignite-3/pull/6790
https://issues.apache.org/jira/browse/IGNITE-26725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26725 Add logging of fsync files for aipersist [ignite-3]
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #6790:
URL: https://github.com/apache/ignite-3/pull/6790#discussion_r2439496946
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointProgressImpl.java:
##########
@@ -154,6 +157,16 @@ public AtomicInteger syncedPagesCounter() {
return syncedPagesCntr;
}
+ /** Returns counter of fsync-ed checkpoint files. */
+ public AtomicInteger syncedFilesCounter() {
Review Comment:
This exercise should then be done for all counters, not just the new one.
To maintain uniformity in the class, I made it similar to the existing ones; a redesign could be just the ticket to Innovation Day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26725 Add logging of fsync files for aipersist [ignite-3]
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill merged PR #6790:
URL: https://github.com/apache/ignite-3/pull/6790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26725 Add logging of fsync files for aipersist [ignite-3]
Posted by "ivanzlenko (via GitHub)" <gi...@apache.org>.
ivanzlenko commented on code in PR #6790:
URL: https://github.com/apache/ignite-3/pull/6790#discussion_r2439557255
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointProgressImpl.java:
##########
@@ -154,6 +157,16 @@ public AtomicInteger syncedPagesCounter() {
return syncedPagesCntr;
}
+ /** Returns counter of fsync-ed checkpoint files. */
+ public AtomicInteger syncedFilesCounter() {
Review Comment:
Oh, I see. Missed syncedPagesCounter shouldn't this method be in the interface as well then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26725 Add logging of fsync files for aipersist [ignite-3]
Posted by "ivanzlenko (via GitHub)" <gi...@apache.org>.
ivanzlenko commented on code in PR #6790:
URL: https://github.com/apache/ignite-3/pull/6790#discussion_r2439478803
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointProgressImpl.java:
##########
@@ -154,6 +157,16 @@ public AtomicInteger syncedPagesCounter() {
return syncedPagesCntr;
}
+ /** Returns counter of fsync-ed checkpoint files. */
+ public AtomicInteger syncedFilesCounter() {
Review Comment:
Also we will forbid any other unintended operations on syncedFilesCntr like setting random value.
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointProgressImpl.java:
##########
@@ -154,6 +157,16 @@ public AtomicInteger syncedPagesCounter() {
return syncedPagesCntr;
}
+ /** Returns counter of fsync-ed checkpoint files. */
+ public AtomicInteger syncedFilesCounter() {
Review Comment:
I would've make increaseSyncedFilesCounter method instead.
We will not tie ourselves to AtomicInteger in that case and can do whatever we want on increment eventually.
And calling it could be slighlty cleaner.
Also we can hide it from prying eyes by making it package-private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26725 Add logging of fsync files for aipersist [ignite-3]
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #6790:
URL: https://github.com/apache/ignite-3/pull/6790#discussion_r2439633479
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointProgressImpl.java:
##########
@@ -154,6 +157,16 @@ public AtomicInteger syncedPagesCounter() {
return syncedPagesCntr;
}
+ /** Returns counter of fsync-ed checkpoint files. */
+ public AtomicInteger syncedFilesCounter() {
Review Comment:
We discussed it in person and will correct it separately later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org