You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Jongjin Choi (JIRA)" <ax...@ws.apache.org> on 2005/02/18 13:19:49 UTC

[jira] Created: (AXIS-1823) SOAPEnvelope's serialization of children is not ordered properly.

SOAPEnvelope's serialization of children is not ordered properly.
-----------------------------------------------------------------

         Key: AXIS-1823
         URL: http://issues.apache.org/jira/browse/AXIS-1823
     Project: Axis
        Type: Bug
    Reporter: Jongjin Choi


SOAPEnvelope's outputImpl() serializes the content of SOAPEnvelope.
But the serialization order is not valid.

For example, 

        SOAPMessage smsg = ... // SOAPMessage with SOAP Header and body            
        SOAPPart sp = smsg.getSOAPPart();
        SOAPEnvelope envelope = sp.getEnvelope();
        envelope.addTextNode("<!-- This is a comment -->");
	smsg.writeTo(System.out);

The expected output will be :

  <soap:Envelope>
    <soap:Header>
      ...
    </soap:Header>
    <soap:Body>
    </soap:Body>
    <!-- This is a comment -->
  </soap:Envelope>

But the actual output is :

  <soap:Envelope>
    <!-- This is a comment -->
    <soap:Header>
      ...
    </soap:Header>
    <soap:Body>
    </soap:Body>
  </soap:Envelope>

The current serialization order of SOAPEnvelope is (in SOAPEnvelope#outputImpl()):
 - non-soapheader and non-soapbody stuff (included Text node)
 - soapheader
 - soapbody
 - trailers

This order is not same as DOM tree order. 
(Also it is not clear what the trailers are. I can't find examples which uses the trailers.)

The right serialization is to iterate the children and serialize each as it appears.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (AXIS-1823) SOAPEnvelope's serialization of children is not ordered properly.

Posted by "Jongjin Choi (JIRA)" <ax...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/AXIS-1823?page=history ]

Jongjin Choi updated AXIS-1823:
-------------------------------

      Assign To: Jongjin Choi
        Version: current (nightly)
      Component: SAAJ
    Fix Version: current (nightly)

> SOAPEnvelope's serialization of children is not ordered properly.
> -----------------------------------------------------------------
>
>          Key: AXIS-1823
>          URL: http://issues.apache.org/jira/browse/AXIS-1823
>      Project: Axis
>         Type: Bug
>   Components: SAAJ
>     Versions: current (nightly)
>     Reporter: Jongjin Choi
>     Assignee: Jongjin Choi
>      Fix For: current (nightly)

>
> SOAPEnvelope's outputImpl() serializes the content of SOAPEnvelope.
> But the serialization order is not valid.
> For example, 
>         SOAPMessage smsg = ... // SOAPMessage with SOAP Header and body            
>         SOAPPart sp = smsg.getSOAPPart();
>         SOAPEnvelope envelope = sp.getEnvelope();
>         envelope.addTextNode("<!-- This is a comment -->");
> 	smsg.writeTo(System.out);
> The expected output will be :
>   <soap:Envelope>
>     <soap:Header>
>       ...
>     </soap:Header>
>     <soap:Body>
>     </soap:Body>
>     <!-- This is a comment -->
>   </soap:Envelope>
> But the actual output is :
>   <soap:Envelope>
>     <!-- This is a comment -->
>     <soap:Header>
>       ...
>     </soap:Header>
>     <soap:Body>
>     </soap:Body>
>   </soap:Envelope>
> The current serialization order of SOAPEnvelope is (in SOAPEnvelope#outputImpl()):
>  - non-soapheader and non-soapbody stuff (included Text node)
>  - soapheader
>  - soapbody
>  - trailers
> This order is not same as DOM tree order. 
> (Also it is not clear what the trailers are. I can't find examples which uses the trailers.)
> The right serialization is to iterate the children and serialize each as it appears.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (AXIS-1823) SOAPEnvelope's serialization of children is not ordered properly.

Posted by "Jongjin Choi (JIRA)" <ax...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/AXIS-1823?page=history ]
     
Jongjin Choi resolved AXIS-1823:
--------------------------------

    Resolution: Fixed

applied patch

> SOAPEnvelope's serialization of children is not ordered properly.
> -----------------------------------------------------------------
>
>          Key: AXIS-1823
>          URL: http://issues.apache.org/jira/browse/AXIS-1823
>      Project: Axis
>         Type: Bug
>   Components: SAAJ
>     Versions: current (nightly)
>     Reporter: Jongjin Choi
>     Assignee: Jongjin Choi
>      Fix For: current (nightly)

>
> SOAPEnvelope's outputImpl() serializes the content of SOAPEnvelope.
> But the serialization order is not valid.
> For example, 
>         SOAPMessage smsg = ... // SOAPMessage with SOAP Header and body            
>         SOAPPart sp = smsg.getSOAPPart();
>         SOAPEnvelope envelope = sp.getEnvelope();
>         envelope.addTextNode("<!-- This is a comment -->");
> 	smsg.writeTo(System.out);
> The expected output will be :
>   <soap:Envelope>
>     <soap:Header>
>       ...
>     </soap:Header>
>     <soap:Body>
>     </soap:Body>
>     <!-- This is a comment -->
>   </soap:Envelope>
> But the actual output is :
>   <soap:Envelope>
>     <!-- This is a comment -->
>     <soap:Header>
>       ...
>     </soap:Header>
>     <soap:Body>
>     </soap:Body>
>   </soap:Envelope>
> The current serialization order of SOAPEnvelope is (in SOAPEnvelope#outputImpl()):
>  - non-soapheader and non-soapbody stuff (included Text node)
>  - soapheader
>  - soapbody
>  - trailers
> This order is not same as DOM tree order. 
> (Also it is not clear what the trailers are. I can't find examples which uses the trailers.)
> The right serialization is to iterate the children and serialize each as it appears.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira