You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/30 08:56:46 UTC
[GitHub] alexarchambault commented on issue #23607: [SPARK-26681][SQL]
Support Ammonite inner-class scopes.
alexarchambault commented on issue #23607: [SPARK-26681][SQL] Support Ammonite inner-class scopes.
URL: https://github.com/apache/spark/pull/23607#issuecomment-458863676
This was added in the context of [ammonite-spark](https://github.com/alexarchambault/ammonite-spark), which is a project of mine… There's some details about it in its [README](https://github.com/alexarchambault/ammonite-spark/blob/master/README.md) and the INTERNALS.md document in the ammonite-spark repo.
I guess adding a `def addOuterScopes(pf: String => AnyRef): Unit` to add one's own outer scopes at once, instead of the hard-coded `AmmoniteREPLClass` of this PR, would have worked as well, and would have been more generic and not tied to details that could change in both Ammonite or ammonite-spark.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org