You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/01 08:44:00 UTC

[GitHub] [inlong] fuweng11 opened a new pull request, #6354: [INLONG-6352][Manager] Set whether to push the sort configuration through zk using the global configuration

fuweng11 opened a new pull request, #6354:
URL: https://github.com/apache/inlong/pull/6354

   ### Prepare a Pull Request
   *(Change the title refer to the following example)*
   
   - Fixes #6352 
   
   ### Motivation
   
   Set whether to push the sort configuration through zk using the global configuration
   ### Modifications
   
   The global configuration `sort.enable.zookeeper` has been added to the configuration file.
   This configuration is used to determine whether to push the sort configuration to zk.
   ### Verifying this change
   
   *(Please pick either of the following options)*
   
   - [X] This change is a trivial rework/code cleanup without any test coverage.
   
   - [ ] This change is already covered by existing tests, such as:
     *(please describe tests)*
   
   - [ ] This change added tests and can be verified as follows:
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #6354: [INLONG-6352][Manager] Set whether to push the sort configuration through zk using the global configuration

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6354:
URL: https://github.com/apache/inlong/pull/6354#discussion_r1010225086


##########
inlong-manager/manager-web/src/main/resources/application-dev.properties:
##########
@@ -82,3 +82,6 @@ data.cleansing.interval.seconds=1800
 data.cleansing.before.days=10
 # The maximum size of data to be deleted in batch, default is 100
 data.cleansing.batchSize=100
+
+# Whether to push sort configuration through zk

Review Comment:
   ```suggestion
   # Whether to use ZooKeeper to manage the Sort task config, default is false, which means not use ZooKeeper
   ```



##########
inlong-manager/manager-web/src/main/resources/application-dev.properties:
##########
@@ -82,3 +82,6 @@ data.cleansing.interval.seconds=1800
 data.cleansing.before.days=10
 # The maximum size of data to be deleted in batch, default is 100
 data.cleansing.batchSize=100
+
+# Whether to push sort configuration through zk

Review Comment:
   ```suggestion
   # Whether to use ZooKeeper to manage the Sort task config, default is false, which means not using ZooKeeper
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #6354: [INLONG-6352][Manager] Set whether to push the sort configuration through zk using the global configuration

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6354:
URL: https://github.com/apache/inlong/pull/6354#discussion_r1010222513


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -246,6 +250,7 @@ public String update(InlongGroupRequest request, String operator) {
         // check whether the current status can be modified
         checkGroupCanUpdate(entity, request, operator);
 
+        request.setEnableZookeeper(enableZookeeper ? 1 : 0);

Review Comment:
   Suggest using `InlongConstants.DISABLE_ZK` instead a magic number.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #6354: [INLONG-6352][Manager] Set whether to push the sort configuration through zk using the global configuration

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6354:
URL: https://github.com/apache/inlong/pull/6354#discussion_r1010225086


##########
inlong-manager/manager-web/src/main/resources/application-dev.properties:
##########
@@ -82,3 +82,6 @@ data.cleansing.interval.seconds=1800
 data.cleansing.before.days=10
 # The maximum size of data to be deleted in batch, default is 100
 data.cleansing.batchSize=100
+
+# Whether to push sort configuration through zk

Review Comment:
   ```suggestion
   # Whether to use ZooKeeper to manage the Sort task config, the default is false, not use ZooKeeper
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow merged pull request #6354: [INLONG-6352][Manager] Add a global config for whether to use ZooKeeper to manage the Sort task

Posted by GitBox <gi...@apache.org>.
healchow merged PR #6354:
URL: https://github.com/apache/inlong/pull/6354


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org