You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by pszypowicz <gi...@git.apache.org> on 2015/06/15 12:18:03 UTC

[GitHub] libcloud pull request: Fix/gce firewall default rule

GitHub user pszypowicz opened a pull request:

    https://github.com/apache/libcloud/pull/535

    Fix/gce firewall default rule

    Due to fact that user created source_tags, we shouldn't by default set also source_range = 0.0.0.0/0.
    
    This will be much more secure setting.
    
    Ref: https://cloud.google.com/compute/docs/reference/latest/firewalls#resource

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pszypowicz/libcloud fix/gce_firewall_default_rule

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/535.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #535
    
----
commit a3a662dd8e138048cac71d72f9cc3adee1759d47
Author: Przemysław Szypowicz <ps...@egnyte.com>
Date:   2015-06-15T09:52:43Z

    Due to fact that you created source_tags, we shouldn't by default
    set also source_range = 0.0.0.0/0.
    
    This will be much more secure setting.
    
    Ref: https://cloud.google.com/compute/docs/reference/latest/firewalls#resource

commit 00749705055dd388d6c009f10e3c1252549f3e55
Author: Przemysław Szypowicz <ps...@egnyte.com>
Date:   2015-06-15T09:52:43Z

    Due to fact that you created source_tags, we shouldn't by default
    set also source_range = 0.0.0.0/0.
    
    This will be much more secure setting.
    
    Ref: https://cloud.google.com/compute/docs/reference/latest/firewalls#resource

commit 08c0d4c106270a4d3a2aca04638e90bbf43a14c7
Author: Przemysław Szypowicz <ps...@egnyte.com>
Date:   2015-06-15T10:13:23Z

    Merge branch 'fix/gce_firewall_default_rule' of https://github.com/pszypowicz/libcloud into fix/gce_firewall_default_rule

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] libcloud pull request: Fix/gce firewall default rule

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/libcloud/pull/535


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---