You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by to...@apache.org on 2011/09/14 08:48:08 UTC
svn commit: r1170450 - in
/hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common:
CHANGES.txt src/main/java/org/apache/hadoop/fs/permission/FsPermission.java
Author: todd
Date: Wed Sep 14 06:48:08 2011
New Revision: 1170450
URL: http://svn.apache.org/viewvc?rev=1170450&view=rev
Log:
HADOOP-7629. Allow immutable FsPermission objects to be used as IPC parameters. Contributed by Todd Lipcon.
Modified:
hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/FsPermission.java
Modified: hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt?rev=1170450&r1=1170449&r2=1170450&view=diff
==============================================================================
--- hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt (original)
+++ hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt Wed Sep 14 06:48:08 2011
@@ -573,6 +573,9 @@ Release 0.23.0 - Unreleased
HADOOP-7626. Bugfix for a config generator (Eric Yang via ddas)
+ HADOOP-7629. Allow immutable FsPermission objects to be used as IPC
+ parameters. (todd)
+
Release 0.22.0 - Unreleased
INCOMPATIBLE CHANGES
Modified: hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/FsPermission.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/FsPermission.java?rev=1170450&r1=1170449&r2=1170450&view=diff
==============================================================================
--- hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/FsPermission.java (original)
+++ hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/FsPermission.java Wed Sep 14 06:48:08 2011
@@ -44,18 +44,12 @@ public class FsPermission implements Wri
};
static { // register a ctor
WritableFactories.setFactory(FsPermission.class, FACTORY);
+ WritableFactories.setFactory(ImmutableFsPermission.class, FACTORY);
}
/** Create an immutable {@link FsPermission} object. */
public static FsPermission createImmutable(short permission) {
- return new FsPermission(permission) {
- public FsPermission applyUMask(FsPermission umask) {
- throw new UnsupportedOperationException();
- }
- public void readFields(DataInput in) throws IOException {
- throw new UnsupportedOperationException();
- }
- };
+ return new ImmutableFsPermission(permission);
}
//POSIX permission style
@@ -301,4 +295,16 @@ public class FsPermission implements Wri
return new FsPermission((short)n);
}
+
+ private static class ImmutableFsPermission extends FsPermission {
+ public ImmutableFsPermission(short permission) {
+ super(permission);
+ }
+ public FsPermission applyUMask(FsPermission umask) {
+ throw new UnsupportedOperationException();
+ }
+ public void readFields(DataInput in) throws IOException {
+ throw new UnsupportedOperationException();
+ }
+ }
}