You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by milantracy <gi...@git.apache.org> on 2018/06/20 19:21:16 UTC
[GitHub] storm pull request #2729: STORM-3064: PartitionedTridentSpoutExecutor should...
GitHub user milantracy opened a pull request:
https://github.com/apache/storm/pull/2729
STORM-3064: PartitionedTridentSpoutExecutor should use getPartitionsF…
…orTask
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/milantracy/storm storm3064
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2729.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2729
----
commit 8a40d53ef2eedbfcade23ecfd02d0a287cd4b530
Author: Jing Chen <mi...@...>
Date: 2018-06-20T17:48:00Z
STORM-3064: PartitionedTridentSpoutExecutor should use getPartitionsForTask
----
---
[GitHub] storm pull request #2729: STORM-3064: PartitionedTridentSpoutExecutor should...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2729
---
[GitHub] storm issue #2729: STORM-3064: PartitionedTridentSpoutExecutor should use ge...
Posted by milantracy <gi...@git.apache.org>.
Github user milantracy commented on the issue:
https://github.com/apache/storm/pull/2729
@srdo could you review this pull request
---
[GitHub] storm issue #2729: STORM-3064: PartitionedTridentSpoutExecutor should use ge...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2729
+1, looks good.
---
[GitHub] storm pull request #2729: STORM-3064: PartitionedTridentSpoutExecutor should...
Posted by milantracy <gi...@git.apache.org>.
Github user milantracy commented on a diff in the pull request:
https://github.com/apache/storm/pull/2729#discussion_r197235311
--- Diff: storm-client/src/jvm/org/apache/storm/trident/spout/IPartitionedTridentSpout.java ---
@@ -36,7 +37,7 @@
interface Coordinator<Partitions> {
/**
* Return the partitions currently in the source of data. The idea is is that if a new partition is added and a prior transaction is
- * replayed, it doesn't emit tuples for the new partition because it knows what partitions were in that transaction.
+ * replayed, it doesn't emit tuples for the new partition because it knows what partitions were in that transaction.jobh
*/
--- End diff --
thanks for comments folks, I remove typos here and add more comments
---
[GitHub] storm issue #2729: STORM-3064: PartitionedTridentSpoutExecutor should use ge...
Posted by milantracy <gi...@git.apache.org>.
Github user milantracy commented on the issue:
https://github.com/apache/storm/pull/2729
@srdo @danny0405 squashed, thanks for reviewing :)
---
[GitHub] storm issue #2729: STORM-3064: PartitionedTridentSpoutExecutor should use ge...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2729
@milantracy Looks great. Please squash to one commit, and we can merge once the 24 hour waiting period is over.
---
[GitHub] storm pull request #2729: STORM-3064: PartitionedTridentSpoutExecutor should...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2729#discussion_r197162525
--- Diff: storm-client/src/jvm/org/apache/storm/trident/spout/IPartitionedTridentSpout.java ---
@@ -36,7 +37,7 @@
interface Coordinator<Partitions> {
/**
* Return the partitions currently in the source of data. The idea is is that if a new partition is added and a prior transaction is
- * replayed, it doesn't emit tuples for the new partition because it knows what partitions were in that transaction.
+ * replayed, it doesn't emit tuples for the new partition because it knows what partitions were in that transaction.jobh
*/
--- End diff --
Whoops, yes. Please remove this.
---
[GitHub] storm pull request #2729: STORM-3064: PartitionedTridentSpoutExecutor should...
Posted by danny0405 <gi...@git.apache.org>.
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2729#discussion_r197158924
--- Diff: storm-client/src/jvm/org/apache/storm/trident/spout/IPartitionedTridentSpout.java ---
@@ -36,7 +37,7 @@
interface Coordinator<Partitions> {
/**
* Return the partitions currently in the source of data. The idea is is that if a new partition is added and a prior transaction is
- * replayed, it doesn't emit tuples for the new partition because it knows what partitions were in that transaction.
+ * replayed, it doesn't emit tuples for the new partition because it knows what partitions were in that transaction.jobh
*/
--- End diff --
Sorry, what is the jobh mean?
---