You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/12/11 10:50:29 UTC

[GitHub] [shenyu] yu199195 commented on a diff in pull request #4258: [Task]support diff nacos namespace

yu199195 commented on code in PR #4258:
URL: https://github.com/apache/shenyu/pull/4258#discussion_r1045211424


##########
shenyu-plugin/shenyu-plugin-dubbo/shenyu-plugin-apache-dubbo/src/main/java/org/apache/shenyu/plugin/apache/dubbo/cache/ApacheDubboConfigCache.java:
##########
@@ -155,17 +157,26 @@ public ReferenceConfig<GenericService> build(final MetaData metaData) {
         reference.setAsync(true);
         
         reference.setApplication(applicationConfig);
-        reference.setRegistry(registryConfig);
+        if (StringUtils.isNotBlank(metaData.getNamespace())) {
+            PluginData pluginData = BaseDataCache.getInstance().obtainPluginData(RegisterTypeEnum.DUBBO.getName());
+            if (pluginData != null) {
+                String config = BaseDataCache.getInstance().obtainPluginData(RegisterTypeEnum.DUBBO.getName()).getConfig();

Review Comment:
   used pluginData.getConfig();?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org