You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2018/01/03 22:51:53 UTC

Review Request 64933: Fixed flaky PartitionedSlaveReregistrationMasterFailover test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64933/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov and Megha Sharma.


Bugs: MESOS-8334
    https://issues.apache.org/jira/browse/MESOS-8334


Repository: mesos


Description
-------

The test was flaky due to a race condition that causes status updates
to be dropped because the agent reregisters before the schedulers.


Diffs
-----

  src/tests/partition_tests.cpp 7f4b9ed938fd478fdf750b464c531bf76de7d798 


Diff: https://reviews.apache.org/r/64933/diff/1/


Testing
-------

make check. Ran the affected test for 1000 iterations.


Thanks,

Jiang Yan Xu


Re: Review Request 64933: Fixed flaky PartitionedSlaveReregistrationMasterFailover test.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64933/#review194744
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Jan. 3, 2018, 10:51 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64933/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2018, 10:51 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Megha Sharma.
> 
> 
> Bugs: MESOS-8334
>     https://issues.apache.org/jira/browse/MESOS-8334
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The test was flaky due to a race condition that causes status updates
> to be dropped because the agent reregisters before the schedulers.
> 
> 
> Diffs
> -----
> 
>   src/tests/partition_tests.cpp 7f4b9ed938fd478fdf750b464c531bf76de7d798 
> 
> 
> Diff: https://reviews.apache.org/r/64933/diff/1/
> 
> 
> Testing
> -------
> 
> make check. Ran the affected test for 1000 iterations.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>