You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Stefan Miklosovic (Jira)" <ji...@apache.org> on 2022/09/02 14:39:00 UTC

[jira] [Comment Edited] (CASSANDRA-17876) remove the unused imports in the source code

    [ https://issues.apache.org/jira/browse/CASSANDRA-17876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599520#comment-17599520 ] 

Stefan Miklosovic edited comment on CASSANDRA-17876 at 9/2/22 2:38 PM:
-----------------------------------------------------------------------

This is good initiative but we should tackle this in more robust way. We already have checkstyle in place (at least for trunk, in checkstyle.xml) and there is UnusedImports module for it we currently do not use (1). In my opinion, ideally, we should use this so a developer can run respective Ant task on his own before ever committing something in the first place.

(1) https://checkstyle.org/config_imports.html#UnusedImports

Something like this

https://github.com/instaclustr/cassandra/commit/63d44f739f4920d93948461a4a89a0c5fb904ffa

 then "ant checkstyle" fails (as it currently should).


was (Author: smiklosovic):
This is good initiative but we should tackle this in more robust way. We already have checkstyle in place (at least for trunk, in checkstyle.xml) and there is UnusedImports module for it we currently do not use (1). In my opinion, ideally, we should use this so a developer can run respective Ant task on his own before ever committing something in the first place.

(1) https://checkstyle.org/config_imports.html#UnusedImports

> remove the unused imports in the source code
> --------------------------------------------
>
>                 Key: CASSANDRA-17876
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17876
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Ling Mao
>            Assignee: Ling Mao
>            Priority: Normal
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> remove the unused imports in the source code



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org