You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/30 20:51:51 UTC

[GitHub] [tvm] areusch commented on a diff in pull request #11976: [docker] Fall back to tlcpackstaging in bash.sh

areusch commented on code in PR #11976:
URL: https://github.com/apache/tvm/pull/11976#discussion_r911435540


##########
docker/bash.sh:
##########
@@ -290,7 +290,11 @@ DOCKER_DEVICES=( )
 # If the user gave a shortcut defined in the Jenkinsfile, use it.
 EXPANDED_SHORTCUT=$(lookup_image_spec "${DOCKER_IMAGE_NAME}")
 if [ -n "${EXPANDED_SHORTCUT}" ]; then
-    DOCKER_IMAGE_NAME="${EXPANDED_SHORTCUT}"
+    python tests/scripts/determine_docker_images.py "$DOCKER_IMAGE_NAME=$EXPANDED_SHORTCUT" 2> /dev/null

Review Comment:
   should we also check if `CI` is defined and not do this then, so that we don't double-`determine_docker_images.py` in CI?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org