[jira] [Updated] (HBASE-28810) Improve BackupLogCleaner naming, debug logging

["Nick Dimiduk (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-28810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nick Dimiduk updated HBASE-28810:
---------------------------------
    Summary: Improve BackupLogCleaner naming, debug logging  (was: BackupLogCleaner is difficult to debug)

> Improve BackupLogCleaner naming, debug logging
> ----------------------------------------------
>
>                 Key: HBASE-28810
>                 URL: https://issues.apache.org/jira/browse/HBASE-28810
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.6.0, 2.6.1
>            Reporter: Ray Mattingly
>            Assignee: Ray Mattingly
>            Priority: Major
>              Labels: pull-request-available
>
> While implementing HBase's incremental backups across a few hundred clusters, we continue to step on some rakes. Now and again, we find old WALs piling up due to a poorly cleaned up BackupInfo, or a bug in the BackupLogCleaner, etc.
> The BackupLogCleaner is difficult to debug for a couple of reasons:
>  # It has a lack of useful debug logging
>  # It has [a misleadingly named method|https://github.com/HubSpot/hbase/blob/2d08fa67dfe9458260bc0be3ebc7bbd769850190/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/BackupLogCleaner.java#L83-L83] (this method returns the newest backup ts, not the oldest)
> I'm going to introduce a small refactor that will alleviate these pain points.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)