You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2023/08/15 15:36:45 UTC

[GitHub] [tvm] Lunderberg opened a new pull request, #15561: [Unity] Track callees from external functions in DeadCodeElimination

Lunderberg opened a new pull request, #15561:
URL: https://github.com/apache/tvm/pull/15561

   Prior to this commit, the DeadCodeElimination pass avoided removing externally-exposed functions, only checked for callees from user-specified functions.  If an external function wasn't specified, the dead-code elimination could remove a callee resulting in a dangling `GlobalVar`.
   
   This commit updates the dead code elimination to treat all externally-exposed functions as potential entry points. User-specified functions can still be provided, and are treated as additional entry points.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #15561: [Unity] Track callees from external functions in DeadCodeElimination

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.

tvm-bot commented on PR #15561:
URL: https://github.com/apache/tvm/pull/15561#issuecomment-1679155892

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] csullivan merged pull request #15561: [Unity][Transform] Track callees from external functions in DeadCodeElimination

Posted by "csullivan (via GitHub)" <gi...@apache.org>.

csullivan merged PR #15561:
URL: https://github.com/apache/tvm/pull/15561


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org