[jira] [Commented] (HIVE-18865) Check filesystem calls return value (codescan)

["Sahil Takiar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-18865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386709#comment-16386709 ] 

Sahil Takiar commented on HIVE-18865:
-------------------------------------

Just curious, do you mean a codescan tool was used to generate these warnings? What codescan tool was used?

> Check filesystem calls return value (codescan)
> ----------------------------------------------
>
>                 Key: HIVE-18865
>                 URL: https://issues.apache.org/jira/browse/HIVE-18865
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Priority: Major
>
> There are a few places where return value of certain filesystem operations are not being checked.
> Hive should at the very least log these failures.
> 1. Overview : The method saveDir() in BeeLineOpts.java ignores the value returned by mkdirs() on line 174, which could cause the program to overlook unexpected states and conditions.
> In the file BeeLineOpts.java similar issues were on line numbers 174
> 2. Overview : The method compile() in CompileProcessor.java ignores the value returned by mkdir() on line 226, which could cause the program to overlook unexpected states and conditions.
> In the file CompileProcessor.java similar issues were on line numbers 234, 226
> 3. Overview : The method deleteTmpFile() in FileUtils.java ignores the value returned by delete() on line 939, which could cause the program to overlook unexpected states and conditions.
> In the file FileUtils.java similar issues were on line numbers 939



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)