You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/19 02:08:44 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on pull request #4798: [Improvement][api] Introduce base service interface for clear code and unify all controllers, services and tests of api
codecov-io edited a comment on pull request #4798:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4798#issuecomment-781761578
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798?src=pr&el=h1) Report
> Merging [#4798](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798?src=pr&el=desc) (b97ee89) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/15a5b0588399bbafd201405af02d611d548fac12?el=desc) (15a5b05) will **decrease** coverage by `0.29%`.
> The diff coverage is `90.90%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4798 +/- ##
============================================
- Coverage 45.48% 45.18% -0.30%
+ Complexity 3421 3399 -22
============================================
Files 537 538 +1
Lines 23051 23051
Branches 2688 2686 -2
============================================
- Hits 10484 10416 -68
- Misses 11631 11705 +74
+ Partials 936 930 -6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...cheduler/api/controller/AccessTokenController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvQWNjZXNzVG9rZW5Db250cm9sbGVyLmphdmE=) | `8.33% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...scheduler/api/controller/AlertGroupController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvQWxlcnRHcm91cENvbnRyb2xsZXIuamF2YQ==) | `5.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../api/controller/AlertPluginInstanceController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvQWxlcnRQbHVnaW5JbnN0YW5jZUNvbnRyb2xsZXIuamF2YQ==) | `5.71% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...olphinscheduler/api/controller/BaseController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvQmFzZUNvbnRyb2xsZXIuamF2YQ==) | `53.75% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| [...heduler/api/controller/DataAnalysisController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvRGF0YUFuYWx5c2lzQ29udHJvbGxlci5qYXZh) | `9.09% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...scheduler/api/controller/DataSourceController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvRGF0YVNvdXJjZUNvbnRyb2xsZXIuamF2YQ==) | `4.65% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...inscheduler/api/controller/ExecutorController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvRXhlY3V0b3JDb250cm9sbGVyLmphdmE=) | `11.11% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...phinscheduler/api/controller/LoggerController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvTG9nZ2VyQ29udHJvbGxlci5qYXZh) | `20.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...lphinscheduler/api/controller/LoginController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvTG9naW5Db250cm9sbGVyLmphdmE=) | `8.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...hinscheduler/api/controller/MonitorController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvTW9uaXRvckNvbnRyb2xsZXIuamF2YQ==) | `13.33% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| ... and [58 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798?src=pr&el=footer). Last update [15a5b05...b97ee89](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4798?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org