You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@httpd.apache.org by GitBox <gi...@apache.org> on 2021/05/01 08:57:48 UTC
[GitHub] [httpd] byshen opened a new pull request #183: Add reasons before returning declined in mod_dialup
byshen opened a new pull request #183:
URL: https://github.com/apache/httpd/pull/183
* modules/test/mod_dialup.c : apr_file_open() may fail in the dialup handler, so leave a log message before simply return declined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org
[GitHub] [httpd] byshen commented on a change in pull request #183: Add reasons before returning declined in mod_dialup
Posted by GitBox <gi...@apache.org>.
byshen commented on a change in pull request #183:
URL: https://github.com/apache/httpd/pull/183#discussion_r630402742
##########
File path: modules/test/mod_dialup.c
##########
@@ -181,6 +181,9 @@ dialup_handler(request_rec *r)
, 0, r->pool);
if (rv) {
+ ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO()
Review comment:
Updated it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org
[GitHub] [httpd] notroj commented on a change in pull request #183: Add reasons before returning declined in mod_dialup
Posted by GitBox <gi...@apache.org>.
notroj commented on a change in pull request #183:
URL: https://github.com/apache/httpd/pull/183#discussion_r628247568
##########
File path: modules/test/mod_dialup.c
##########
@@ -181,6 +181,9 @@ dialup_handler(request_rec *r)
, 0, r->pool);
if (rv) {
+ ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO()
Review comment:
This should log the rv rather than passing 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org