[GitHub] [sling-org-apache-sling-graphql-core] tyge68 commented on a change in pull request #15: SLING-10018 Implement SelectionSet / SelectedField wrappers

[GitBox <gi...@apache.org>]

tyge68 commented on a change in pull request #15:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/15#discussion_r551954024



##########
File path: src/test/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutorTest.java
##########
@@ -188,4 +191,30 @@ public void unionFetcherTest() throws Exception {
         assertThat(json, hasJsonPath("$.data.unionFetcher.items[0].testingArgument", equalTo("1, 2, 3")));
         assertThat(json, hasJsonPath("$.data.unionFetcher.items[1].path", equalTo(resource.getPath())));
     }
+
+    @Test
+    public void selectionSetTest() throws Exception {

Review comment:
       I will add a that in the test, only "inline" so currently in our cases Union would have the "type" as the name of the field.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org