[GitHub] [spark] grundprinzip commented on a diff in pull request #39084: [SPARK-41464][CONNECT][PYTHON] Implement `DataFrame.to`

[GitBox <gi...@apache.org>]

grundprinzip commented on code in PR #39084:
URL: https://github.com/apache/spark/pull/39084#discussion_r1052226595


##########
python/pyspark/sql/tests/connect/test_connect_plan_only.py:
##########
@@ -498,6 +499,19 @@ def test_coalesce_and_repartition(self):
             df.repartition(-1)._plan.to_proto(self.connect)
         self.assertTrue("numPartitions must be positive" in str(context.exception))
 
+    def test_to(self):
+        # SPARK-41464: test `to` API in Python client.

Review Comment:
   please add a negative test case as well. Eg. trying to project a column that does not exist, uncastable data type etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org