Re: [Patch] Allow running 'make check' with PyPy.

[Yasuhito FUTATSUKI <fu...@yf.bsdclub.org>]

On 2020/11/12 0:52, Yasuhito FUTATSUKI wrote:
> On 2020/11/11 23:58, Nathan Hartman wrote:
>> On Wed, Nov 11, 2020 at 2:15 AM Yasuhito FUTATSUKI <fu...@yf.bsdclub.org>
>> wrote:
>>
>>>
>>> I don't think we support to run tests on PyPy but also I don't think
>>> it is worthless.
>>>
>>> Any thoughts?
>>
>>
>> Even if we don't officially support it, I think it is worthwhile. The more
>> different ways we can run the test suite, the more likely we could uncover
>> some subtle bugs.
>>
>> I would be interested to run the test suite with PyPy and measure the time,
>> to compare with the standard way of running it.
>>
>> Did you have to take any special steps to run it?
> 
> Thank you for your reply.
> 
> Nothing but replacing PYTHON= in Makefile already configured ... or even 
> doing configure with setting environment variable PYTHON to point PyPy
> works.

I confirmed that make check causes "To many open files" error on

* Pypy2.7 v7.3.0 on FreeBSD 12 (ulimit -n: 175833)
* Pypy3.6 v7.3.0 on FreeBSD 12 (ulimit -n: 175833)
* Pypy3.7 v7.3.3 on CentOS 7   (ulimit -n: 1024)

and the patch fixed it.

So I've committed it in 1884279.

Cheers,
-- 
Yasuhito FUTATSUKI <fu...@yf.bsclub.org>