[GitHub] [incubator-nuttx] hartmannathan commented on pull request #3532: stm32g4xx: add support for PWM

[GitBox <gi...@apache.org>]

hartmannathan commented on pull request #3532:
URL: https://github.com/apache/incubator-nuttx/pull/3532#issuecomment-819034982


   I think the G4 chips use a different version of Timers IP than TIMERS_V2. The register definitions are very similar to TIMERS_V2 but I think there are some discrepancies, including added registers (more features) and also (I think) some changed registers and bitfields, so your implementation might not work right if code tries to use certain bitfields.
   
   Some time ago I began work to add the register definitions for STM32G4 and I think it's substantially complete, but I didn't open a PR at the time because I first wanted to see if my changes should be merged into the existing TIMERS_V2 header, or be left as a separate file.
   
   It can be found in the stm32-tim-improve branch of my fork:
   
   https://github.com/hartmannathan/incubator-nuttx/commit/d5db24c029ef25c732f0240cd2c74a1de5685b7a
   
   I can't work on it right now but feel free to use pieces of it, or let me know if you think it's acceptable as-is (as a separate file) and I'll open a PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org