[GitHub] [spark] rdblue commented on a change in pull request #24594: [SPARK-27693][SQL] Add default catalog property

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #24594: [SPARK-27693][SQL] Add default catalog property
URL: https://github.com/apache/spark/pull/24594#discussion_r285665290
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -1767,6 +1767,11 @@ object SQLConf {
         "with String")
     .booleanConf
     .createWithDefault(false)
+
+  val DEFAULT_V2_CATALOG = buildConf("spark.sql.default.catalog")
 
 Review comment:
   The reason for this order is that `spark.sql.catalog.(name)` properties are used to register catalogs. So the property name you suggest creates a catalog named "default" using the existing convention. We could change the properties to use `catalogs` instead if you'd prefer. Then the `catalog.default` name would not conflict.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org