You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/31 02:19:11 UTC

[GitHub] [shardingsphere] huanghao495430759 opened a new pull request #10561: add global rule changed listener factory,update governance doc

huanghao495430759 opened a new pull request #10561:
URL: https://github.com/apache/shardingsphere/pull/10561


   - add global rule changed listener factory
   - add GlobalRuleChangedListenerFactory desc to governance doc.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #10561: add global rule changed listener factory,update governance doc

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on a change in pull request #10561:
URL: https://github.com/apache/shardingsphere/pull/10561#discussion_r642311887



##########
File path: shardingsphere-governance/shardingsphere-governance-core/src/main/resources/META-INF/services/org.apache.shardingsphere.governance.core.registry.listener.GovernanceListenerFactory
##########
@@ -20,3 +20,4 @@ org.apache.shardingsphere.governance.core.registry.listener.factory.DataSourceSt
 org.apache.shardingsphere.governance.core.registry.listener.factory.LockChangedListenerFactory
 org.apache.shardingsphere.governance.core.registry.listener.factory.PropertiesChangedListenerFactory
 org.apache.shardingsphere.governance.core.registry.listener.factory.MetaDataChangedListenerFactory
+org.apache.shardingsphere.governance.core.registry.listener.factory.GlobalRuleChangedListenerFactory

Review comment:
       looking forward your next PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] huanghao495430759 commented on a change in pull request #10561: add global rule changed listener factory,update governance doc

Posted by GitBox <gi...@apache.org>.
huanghao495430759 commented on a change in pull request #10561:
URL: https://github.com/apache/shardingsphere/pull/10561#discussion_r642258525



##########
File path: shardingsphere-governance/shardingsphere-governance-core/src/main/resources/META-INF/services/org.apache.shardingsphere.governance.core.registry.listener.GovernanceListenerFactory
##########
@@ -20,3 +20,4 @@ org.apache.shardingsphere.governance.core.registry.listener.factory.DataSourceSt
 org.apache.shardingsphere.governance.core.registry.listener.factory.LockChangedListenerFactory
 org.apache.shardingsphere.governance.core.registry.listener.factory.PropertiesChangedListenerFactory
 org.apache.shardingsphere.governance.core.registry.listener.factory.MetaDataChangedListenerFactory
+org.apache.shardingsphere.governance.core.registry.listener.factory.GlobalRuleChangedListenerFactory

Review comment:
       OK




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10561: add global rule changed listener factory,update governance doc

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10561:
URL: https://github.com/apache/shardingsphere/pull/10561#issuecomment-851134967


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10561?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#10561](https://codecov.io/gh/apache/shardingsphere/pull/10561?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1251a8) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e102f179edd5f07c03d6266ec37c0db817ffd18e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e102f17) will **decrease** coverage by `0.00%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/10561/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/10561?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #10561      +/-   ##
   ============================================
   - Coverage     68.62%   68.61%   -0.01%     
   - Complexity      720      721       +1     
   ============================================
     Files          1767     1768       +1     
     Lines         30361    30364       +3     
     Branches       5441     5441              
   ============================================
   + Hits          20834    20835       +1     
   - Misses         7917     7919       +2     
     Partials       1610     1610              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10561?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ener/factory/GlobalRuleChangedListenerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/10561/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9saXN0ZW5lci9mYWN0b3J5L0dsb2JhbFJ1bGVDaGFuZ2VkTGlzdGVuZXJGYWN0b3J5LmphdmE=) | `33.33% <33.33%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10561?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10561?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e102f17...e1251a8](https://codecov.io/gh/apache/shardingsphere/pull/10561?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #10561: add global rule changed listener factory,update governance doc

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on a change in pull request #10561:
URL: https://github.com/apache/shardingsphere/pull/10561#discussion_r642183958



##########
File path: shardingsphere-governance/shardingsphere-governance-core/src/main/resources/META-INF/services/org.apache.shardingsphere.governance.core.registry.listener.GovernanceListenerFactory
##########
@@ -20,3 +20,4 @@ org.apache.shardingsphere.governance.core.registry.listener.factory.DataSourceSt
 org.apache.shardingsphere.governance.core.registry.listener.factory.LockChangedListenerFactory
 org.apache.shardingsphere.governance.core.registry.listener.factory.PropertiesChangedListenerFactory
 org.apache.shardingsphere.governance.core.registry.listener.factory.MetaDataChangedListenerFactory
+org.apache.shardingsphere.governance.core.registry.listener.factory.GlobalRuleChangedListenerFactory

Review comment:
       Could you add UT for GlobalRuleChangedListenerFactor and other factories, you can fix them in next PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss merged pull request #10561: add global rule changed listener factory,update governance doc

Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #10561:
URL: https://github.com/apache/shardingsphere/pull/10561


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org