You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/16 03:59:01 UTC
[GitHub] [flink] ljz2051 opened a new pull request, #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB…
ljz2051 opened a new pull request, #21516:
URL: https://github.com/apache/flink/pull/21516
… native savepoint doesn't have empty shared-state
## What is the purpose of the change
This pull request adds some comments about why snapshot result fo rocksdb native savepoint doesn't have emtry shared-state.
## Brief change log
- Add some comments in RocksDBIncrementalSnapshotOperation#get(CloseableRegistry snapshotCloseableRegistry)
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ljz2051 commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state
Posted by GitBox <gi...@apache.org>.
ljz2051 commented on PR #21516:
URL: https://github.com/apache/flink/pull/21516#issuecomment-1360961571
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ljz2051 commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state
Posted by GitBox <gi...@apache.org>.
ljz2051 commented on PR #21516:
URL: https://github.com/apache/flink/pull/21516#issuecomment-1361409276
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ljz2051 commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state
Posted by GitBox <gi...@apache.org>.
ljz2051 commented on PR #21516:
URL: https://github.com/apache/flink/pull/21516#issuecomment-1362328413
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ljz2051 commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state
Posted by GitBox <gi...@apache.org>.
ljz2051 commented on PR #21516:
URL: https://github.com/apache/flink/pull/21516#issuecomment-1357356911
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ljz2051 commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state
Posted by GitBox <gi...@apache.org>.
ljz2051 commented on PR #21516:
URL: https://github.com/apache/flink/pull/21516#issuecomment-1361446598
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ljz2051 commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state
Posted by GitBox <gi...@apache.org>.
ljz2051 commented on PR #21516:
URL: https://github.com/apache/flink/pull/21516#issuecomment-1357353726
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ljz2051 commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state
Posted by GitBox <gi...@apache.org>.
ljz2051 commented on PR #21516:
URL: https://github.com/apache/flink/pull/21516#issuecomment-1362323900
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ljz2051 commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state
Posted by GitBox <gi...@apache.org>.
ljz2051 commented on PR #21516:
URL: https://github.com/apache/flink/pull/21516#issuecomment-1361437935
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ljz2051 commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state
Posted by GitBox <gi...@apache.org>.
ljz2051 commented on PR #21516:
URL: https://github.com/apache/flink/pull/21516#issuecomment-1362831609
@Myasuka Yes, and the flinkbot CI is also green now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21516:
URL: https://github.com/apache/flink/pull/21516#issuecomment-1354168517
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c20c1bb8a1803cc8ffd4d5f163f18f0d63cc7298",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c20c1bb8a1803cc8ffd4d5f163f18f0d63cc7298",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c20c1bb8a1803cc8ffd4d5f163f18f0d63cc7298 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ljz2051 commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state
Posted by GitBox <gi...@apache.org>.
ljz2051 commented on PR #21516:
URL: https://github.com/apache/flink/pull/21516#issuecomment-1362349616
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state
Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #21516:
URL: https://github.com/apache/flink/pull/21516#issuecomment-1362509538
@ljz2051 do you have a local green CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka closed pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state
Posted by GitBox <gi...@apache.org>.
Myasuka closed pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state
URL: https://github.com/apache/flink/pull/21516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org