[GitHub] [accumulo] EdColeman commented on pull request #2215: Remove the use of SiteConfiguration from FateCommand

[GitBox <gi...@apache.org>]

EdColeman commented on PR #2215:
URL: https://github.com/apache/accumulo/pull/2215#issuecomment-1146694254

   I believe that additional test from @milleruntime fails on current main because the fate command wants access to the accumulo.properties file.  When mini sets up, it uses the accumulo.properties in a mini /conf directory and the properties file is not on the classpath.  Normally the shell IT test is using accumulo-client.properties so not having the accumulo.properties file is **"normal"**.  
   
   The changes in this branch remove the need for accumulo.properties - and that's why it passes here, but fails on current (7f42c7d72a) main.  The test will pass (with other logic changes) on main if the test is modified so that accumulo.properties is set for the FATE command with:
   ```
       System.setProperty("accumulo.properties",  "file://" + getCluster().getConfig().getAccumuloPropsFile().getCanonicalPath());
   ```
   
   I added the test to #2755, and with the logic change, the new test will pass. Once this PR is merged, the test should be modified so that only the client properties file is necessary to pass
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org