You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/08/17 03:13:00 UTC
[GitHub] [servicecomb-java-chassis] david6969xin opened a new pull request #2509: [SCB-1710] catch the throwable from the scheduled pulling task
david6969xin opened a new pull request #2509:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2509
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2509: [SCB-1710] catch the throwable from the scheduled pulling task
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2509:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2509: [SCB-1710] catch the throwable from the scheduled pulling task
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2509:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2509#discussion_r690110669
##########
File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/AppManager.java
##########
@@ -104,4 +104,11 @@ private void loadStaticMicroserviceVersionFactory() {
}
LOGGER.info("staticMicroserviceVersionFactory is {}.", staticMicroserviceVersionFactoryClass);
}
+
+ public void pullInstances() {
Review comment:
Do not modify this. It is incomplete.
##########
File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceManager.java
##########
@@ -106,4 +106,26 @@ private void onMicroserviceNotExistEvent(MicroserviceNotExistEvent event) {
removeMicroservice(event.getMicroserviceName());
}
+
+ public void pullInstances() {
Review comment:
Do not modify this. It is incomplete.
##########
File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/registry/RemoteServiceRegistry.java
##########
@@ -91,7 +89,7 @@ public void run() {
TimeUnit.SECONDS);
taskPool.scheduleAtFixedRate(
- () -> eventBus.post(new PeriodicPullEvent()),
+ new SuppressedRunnableWrapper(appManager::pullInstances),
Review comment:
Do not modify this. It is incomplete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org