You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "chengxilo (via GitHub)" <gi...@apache.org> on 2026/03/05 21:49:57 UTC
[I] Go SDK Add unit tests for command serialization [iggy]
chengxilo opened a new issue, #2883:
URL: https://github.com/apache/iggy/issues/2883
The Go SDK contains many command types that implement `MarshalBinary` to support serialization. However, proper unit tests for most serialization methods are currently missing.
We should add unit tests to verify the correctness of the `MarshalBinary` implementations for these commands.
It is recommended to start working on this after #2881 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Go SDK: Add unit tests for command serialization/deserialization [iggy]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on issue #2883:
URL: https://github.com/apache/iggy/issues/2883#issuecomment-6353903826
@p4rtridge thanks, go ahead with access_token.go. I have added you as an assignee alongside goutamadwant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Go SDK: Add unit tests for command serialization/deserialization [iggy]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on issue #2883:
URL: https://github.com/apache/iggy/issues/2883#issuecomment-5754026072
Checked `foreign/go/internal/command` against the current tree. 44 command types implement `MarshalBinary`, and 11 of them are exercised by a test. The remaining 33 are not, grouped by the file they live in:
- `access_token.go`: `CreatePersonalAccessToken`, `DeletePersonalAccessToken`, `GetPersonalAccessTokens`
- `consumer_group.go`: `CreateConsumerGroup`, `DeleteConsumerGroup`, `GetConsumerGroup`, `GetConsumerGroups`, `JoinConsumerGroup`, `LeaveConsumerGroup`, `SyncConsumerGroup`
- `offset.go`: `DeleteConsumerOffset`, `GetConsumerOffset`, `StoreConsumerOffsetRequest`
- `partition.go`: `CreatePartitions`, `DeletePartitions`
- `session.go`: `LoginWithPersonalAccessToken`, `LogoutUser`
- `stream.go`: `DeleteStream`, `GetStream`, `GetStreams`
- `system.go`: `DescribeOptions`, `GetClient`, `GetClients`, `GetClusterMetadata`, `GetStats`, `Ping`
- `topic.go`: `DeleteTopic`, `GetTopic`, `GetTopics`
- `user.go`: `ChangePassword`, `DeleteUser`, `GetUser`, `GetUsers`
The ones already covered are `CreateStream`, `UpdateStream`, `CreateTopic`, `UpdateTopic`, `CreateUser`, `UpdateUser`, `UpdatePermissions`, `LoginUser`, `SendMessages`, `PollMessages` and `DeleteSegments`, in `stream_test.go`, `topic_test.go`, `update_user_test.go`, `session_test.go`, `message_test.go` and `segment_test.go`. Those are the pattern to copy.
One file is a self-contained piece of work, so this is worth picking up a file at a time rather than all 33 at once. `system.go` is the easiest start: six types, most of them taking no arguments.
Counted by matching `MarshalBinary` receivers against type names appearing in the `_test.go` files, so a type that is referenced but not actually asserted on would show as covered. Treat the 33 as a floor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Go SDK: Add unit tests for command serialization/deserialization [iggy]
Posted by "goutamadwant (via GitHub)" <gi...@apache.org>.
goutamadwant commented on issue #2883:
URL: https://github.com/apache/iggy/issues/2883#issuecomment-5848042622
@justinmclean I started with `system.go` in #4305. can you check if the test style look right? I’ll also continue file by file as suggested. But for the remaining work, would you prefer one file per PR, or small groups of related files. Let me know. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Go SDK: Add unit tests for command serialization/deserialization [iggy]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on issue #2883:
URL: https://github.com/apache/iggy/issues/2883#issuecomment-6331533343
@goutamadwant only access_token.go is left without tests. Are you doing that one, or can @p4rtridge take it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Go SDK: Add unit tests for command serialization/deserialization [iggy]
Posted by "goutamadwant (via GitHub)" <gi...@apache.org>.
goutamadwant commented on issue #2883:
URL: https://github.com/apache/iggy/issues/2883#issuecomment-5883548772
Thanks @justinmclean. I’ve completed the `session.go` and `user.go` serialization tests as the next small batch. #4334
will proceed with other batches while this gets reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Go SDK: Add unit tests for command serialization/deserialization [iggy]
Posted by "goutamadwant (via GitHub)" <gi...@apache.org>.
goutamadwant commented on issue #2883:
URL: https://github.com/apache/iggy/issues/2883#issuecomment-6343947450
Thanks for checking @justinmclean. I started `access_token.go` locally, but I’m not ready to open a test PR ( have few things to take care before i open PR ). @p4rtridge, please go ahead with the remaining test coverage so I don’t hold up #2883. I won’t open an overlapping test PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Go SDK: Add unit tests for command serialization/deserialization [iggy]
Posted by "p4rtridge (via GitHub)" <gi...@apache.org>.
p4rtridge commented on issue #2883:
URL: https://github.com/apache/iggy/issues/2883#issuecomment-6393127109
> 27\. [@p4rtridge](https://github.com/p4rtridge) thanks, go ahead with access_token.go. I have added you as an assignee alongside goutamadwant.
Thank you, @justinmclean. I have completed the serialization tests for `access_token.go` and opened #4640 for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Go SDK: Add unit tests for command serialization/deserialization [iggy]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on issue #2883:
URL: https://github.com/apache/iggy/issues/2883#issuecomment-5656373044
@saie-ch are you still working on this? If not I'll unassign it so someone else can pick it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Go SDK: Add unit tests for command serialization/deserialization [iggy]
Posted by "saie-ch (via GitHub)" <gi...@apache.org>.
saie-ch commented on issue #2883:
URL: https://github.com/apache/iggy/issues/2883#issuecomment-5658368193
> [@saie-ch](https://github.com/saie-ch) are you still working on this? If not I'll unassign it so someone else can pick it up.
@justinmclean please unassign :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Go SDK: Add unit tests for command serialization/deserialization [iggy]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on issue #2883:
URL: https://github.com/apache/iggy/issues/2883#issuecomment-5880970001
small groups of related files seem the easiest to review I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Go SDK: Add unit tests for command serialization/deserialization [iggy]
Posted by "p4rtridge (via GitHub)" <gi...@apache.org>.
p4rtridge commented on issue #2883:
URL: https://github.com/apache/iggy/issues/2883#issuecomment-6331966006
> 23\. [@goutamadwant](https://github.com/goutamadwant) only access_token.go is left without tests. Are you doing that one, or can [@p4rtridge](https://github.com/p4rtridge) take it?
Yeah, I'm happy to add it if @goutamadwant haven't started on it yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Go SDK: Add unit tests for command serialization/deserialization [iggy]
Posted by "saie-ch (via GitHub)" <gi...@apache.org>.
saie-ch commented on issue #2883:
URL: https://github.com/apache/iggy/issues/2883#issuecomment-4040858258
@mmodzelewski, please assign this to me. I'd like to work on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Go SDK: Add unit tests for command serialization/deserialization [iggy]
Posted by "goutamadwant (via GitHub)" <gi...@apache.org>.
goutamadwant commented on issue #2883:
URL: https://github.com/apache/iggy/issues/2883#issuecomment-5842042662
@justinmclean pls assign this to me. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Go SDK: Add unit tests for command serialization/deserialization [iggy]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on issue #2883:
URL: https://github.com/apache/iggy/issues/2883#issuecomment-5842273533
Thanks @goutamadwant all yours
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Go SDK: Add unit tests for command serialization/deserialization [iggy]
Posted by "p4rtridge (via GitHub)" <gi...@apache.org>.
p4rtridge commented on issue #2883:
URL: https://github.com/apache/iggy/issues/2883#issuecomment-6230726220
Hi @justinmclean @goutamadwant Could I also be assigned to this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org