You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "kezhenxu94 (via GitHub)" <gi...@apache.org> on 2023/03/25 12:29:16 UTC
[GitHub] [skywalking-showcase] kezhenxu94 opened a new pull request, #118: Migrate to Helm Chart
kezhenxu94 opened a new pull request, #118:
URL: https://github.com/apache/skywalking-showcase/pull/118
Migrate to Helm Chart for several reasons:
- Better leverage our ecosystem projects like `skywalking-kubernetes` and `skywalking-swck`, which are recommended for our users and they are more realistic in real use case, and thus reduce duplicate works to replicate the same features in pure Kubernetes resources.
- More flexible because we can have fine-grained conditions in the resources with Helm Chart templates.
- Don't rely on users' local installation (version) of tools such as `istioctl`, the only requirement is Helm.
- Easy to add features that are supported in our official eco-system projects, such as, adding new storage options (such as `postgresql`), will be much more easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] kezhenxu94 commented on a diff in pull request #118: Migrate to Helm Chart
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#discussion_r1148366628
##########
deploy/platform/kubernetes/Chart.yaml:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+apiVersion: v2
+name: skywalking-showcase
+home: https://skywalking.apache.org
+version: 0.0.0
+description: Apache SkyWalking showcase
+icon: https://raw.githubusercontent.com/apache/skywalking-kubernetes/master/logo/sw-logo-for-chart.jpg
+sources:
+ - https://github.com/apache/skywalking-showcase
+dependencies:
Review Comment:
From the content here, these versions are Helm Chart versions themselves, not the app version (like `OAP` version), so in fact the previous versions (before this PR) are still the same as before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] kezhenxu94 merged pull request #118: Migrate to Helm Chart
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 merged PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] innerpeacez commented on a diff in pull request #118: Migrate to Helm Chart
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on code in PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#discussion_r1148371963
##########
deploy/platform/kubernetes/Makefile.in:
##########
@@ -18,8 +18,8 @@
.EXPORT_ALL_VARIABLES:
-NAMESPACE ?= default
+NAMESPACE ?= skywalking-showcase
Review Comment:
helm install -n `namespace`, which seems to be the default behavior of `-n`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] kezhenxu94 commented on a diff in pull request #118: Migrate to Helm Chart
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#discussion_r1148378979
##########
deploy/platform/kubernetes/Chart.yaml:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+apiVersion: v2
+name: skywalking-showcase
+home: https://skywalking.apache.org
+version: 0.0.0
+description: Apache SkyWalking showcase
+icon: https://raw.githubusercontent.com/apache/skywalking-kubernetes/master/logo/sw-logo-for-chart.jpg
+sources:
+ - https://github.com/apache/skywalking-showcase
+dependencies:
Review Comment:
Currently the kube-state-metrics is latest 5.0.1
##########
deploy/platform/kubernetes/Chart.yaml:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+apiVersion: v2
+name: skywalking-showcase
+home: https://skywalking.apache.org
+version: 0.0.0
+description: Apache SkyWalking showcase
+icon: https://raw.githubusercontent.com/apache/skywalking-kubernetes/master/logo/sw-logo-for-chart.jpg
+sources:
+ - https://github.com/apache/skywalking-showcase
+dependencies:
Review Comment:
I can update the otel version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] kezhenxu94 commented on pull request #118: Migrate to Helm Chart
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#issuecomment-1483812559
@innerpeacez welcome to try this and advice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] wu-sheng commented on a diff in pull request #118: Migrate to Helm Chart
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#discussion_r1148367084
##########
deploy/platform/kubernetes/Chart.yaml:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+apiVersion: v2
+name: skywalking-showcase
+home: https://skywalking.apache.org
+version: 0.0.0
+description: Apache SkyWalking showcase
+icon: https://raw.githubusercontent.com/apache/skywalking-kubernetes/master/logo/sw-logo-for-chart.jpg
+sources:
+ - https://github.com/apache/skywalking-showcase
+dependencies:
Review Comment:
OK, as this is a new place. Let's add a doc about how to bump up component versions, especially for SkyWalking components.
@wankai123 @kezhenxu94 Another thing about OTEL collector version, we are not bumping up for a while, there is a big gap, we should doc them and try to bump them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] innerpeacez commented on a diff in pull request #118: Migrate to Helm Chart
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on code in PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#discussion_r1148373553
##########
deploy/platform/kubernetes/Makefile.in:
##########
@@ -18,8 +18,8 @@
.EXPORT_ALL_VARIABLES:
-NAMESPACE ?= default
+NAMESPACE ?= skywalking-showcase
Review Comment:
I think it is only necessary to define the namespace in the Makefile. There is no need to explicitly specify the namespace in k8s resouces yaml. The namespace will use .Release.Namespace by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] kezhenxu94 commented on a diff in pull request #118: Migrate to Helm Chart
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#discussion_r1148378655
##########
deploy/platform/kubernetes/Chart.yaml:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+apiVersion: v2
+name: skywalking-showcase
+home: https://skywalking.apache.org
+version: 0.0.0
+description: Apache SkyWalking showcase
+icon: https://raw.githubusercontent.com/apache/skywalking-kubernetes/master/logo/sw-logo-for-chart.jpg
+sources:
+ - https://github.com/apache/skywalking-showcase
+dependencies:
Review Comment:
> @kezhenxu94 Could we upgrade this as well?
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] wu-sheng commented on pull request #118: Migrate to Helm Chart
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#issuecomment-1483818008
> You mean skywalking-kubernetes repo right?
Yes, that.
___
How do we lock the version of helm repo? I can't find the relative changes of make.in in the root.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] kezhenxu94 commented on pull request #118: Migrate to Helm Chart
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#issuecomment-1483816852
> BTW, we should consider a new helm release as many changes have been made.
You mean `skywalking-kubernetes` repo right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] kezhenxu94 commented on a diff in pull request #118: Migrate to Helm Chart
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#discussion_r1148470753
##########
deploy/platform/kubernetes/templates/feature-event/permissions.yaml:
##########
@@ -32,5 +34,6 @@ roleRef:
name: view
subjects:
- kind: ServiceAccount
- namespace: ${NAMESPACE}
+ namespace: {{ .Release.Namespace }}
Review Comment:
> Does the namespace need to be explicitly specified? This should be the default.
I think you take it wrong, this `namespace` is in `subjects`, not in `metadata`, in `metadata` the default value is `{{ .Release.Namespace }}`, but in `subjects`, there is no default value for `namespace` and the `namespace` is required for `subjects` so we have to set it explicitly here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] kezhenxu94 commented on a diff in pull request #118: Migrate to Helm Chart
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#discussion_r1148371646
##########
deploy/platform/kubernetes/Makefile.in:
##########
@@ -18,8 +18,8 @@
.EXPORT_ALL_VARIABLES:
-NAMESPACE ?= default
+NAMESPACE ?= skywalking-showcase
Review Comment:
> Does the namespace need to be explicitly specified? This should be the default.
@innerpeacez we override the namespace here to `skywalking-showcase`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] kezhenxu94 commented on a diff in pull request #118: Migrate to Helm Chart
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#discussion_r1148373789
##########
deploy/platform/kubernetes/Makefile.in:
##########
@@ -18,8 +18,8 @@
.EXPORT_ALL_VARIABLES:
-NAMESPACE ?= default
+NAMESPACE ?= skywalking-showcase
Review Comment:
OK I got your point now, make sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] kezhenxu94 commented on pull request #118: Migrate to Helm Chart
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#issuecomment-1483812342
I'm running the postgresql demos in my environment and will merge this when I think it's ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] innerpeacez commented on pull request #118: Migrate to Helm Chart
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#issuecomment-1483820177
> @innerpeacez welcome to try this and advice
WOW!!! looking forward to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] wu-sheng commented on a diff in pull request #118: Migrate to Helm Chart
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#discussion_r1148377453
##########
deploy/platform/kubernetes/Chart.yaml:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+apiVersion: v2
+name: skywalking-showcase
+home: https://skywalking.apache.org
+version: 0.0.0
+description: Apache SkyWalking showcase
+icon: https://raw.githubusercontent.com/apache/skywalking-kubernetes/master/logo/sw-logo-for-chart.jpg
+sources:
+ - https://github.com/apache/skywalking-showcase
+dependencies:
Review Comment:
@kezhenxu94 Could we upgrade this as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] wu-sheng commented on pull request #118: Migrate to Helm Chart
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#issuecomment-1483815058
I love this idea. Using helm/operator is much better than writing all these again.
BTW, we should consider a new helm release as many changes have been made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] kezhenxu94 commented on a diff in pull request #118: Migrate to Helm Chart
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#discussion_r1148366404
##########
deploy/platform/kubernetes/Chart.yaml:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+apiVersion: v2
+name: skywalking-showcase
+home: https://skywalking.apache.org
+version: 0.0.0
+description: Apache SkyWalking showcase
+icon: https://raw.githubusercontent.com/apache/skywalking-kubernetes/master/logo/sw-logo-for-chart.jpg
+sources:
+ - https://github.com/apache/skywalking-showcase
+dependencies:
Review Comment:
> How do we lock the version of helm repo? I can't find the relative changes of make.in in the root.
@wu-sheng most of the versions are still maintained in the `Makefile.in` file, only the Helm Chart versions in this files are different, they have to be changed in this file, no variable substitutions can be done in `Chart.yaml` file here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] innerpeacez commented on a diff in pull request #118: Migrate to Helm Chart
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on code in PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#discussion_r1148370236
##########
deploy/platform/kubernetes/Chart.yaml:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+apiVersion: v2
+name: skywalking-showcase
+home: https://skywalking.apache.org
+version: 0.0.0
+description: Apache SkyWalking showcase
+icon: https://raw.githubusercontent.com/apache/skywalking-kubernetes/master/logo/sw-logo-for-chart.jpg
+sources:
+ - https://github.com/apache/skywalking-showcase
+dependencies:
Review Comment:
> @wankai123 @kezhenxu94 Another thing about OTEL collector version, we are not bumping up for a while, there is a big gap, we should doc them and try to bump them.
opentelemetry-collector:0.72.0
kube-state-metrics:v2.8.0
I'm using this version with no problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-showcase] innerpeacez commented on a diff in pull request #118: Migrate to Helm Chart
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on code in PR #118:
URL: https://github.com/apache/skywalking-showcase/pull/118#discussion_r1148371288
##########
deploy/platform/kubernetes/templates/feature-event/permissions.yaml:
##########
@@ -32,5 +34,6 @@ roleRef:
name: view
subjects:
- kind: ServiceAccount
- namespace: ${NAMESPACE}
+ namespace: {{ .Release.Namespace }}
Review Comment:
Does the namespace need to be explicitly specified? This should be the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org