You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Julian Dunn (JIRA)" <ji...@codehaus.org> on 2005/04/12 22:45:47 UTC
[jira] Created: (MPSITE-24) site:deploy with "clean"
site:deploy with "clean"
------------------------
Key: MPSITE-24
URL: http://jira.codehaus.org/browse/MPSITE-24
Project: maven-site-plugin
Type: Bug
Components: plugin
Versions: 1.6
Reporter: Julian Dunn
The site:deploy with "clean" (clean target site before deployment) functionality does not respect the args set in maven.ssh.args. This causes problems if the maven.ssh.args property specifies a particular SSH keypair to use; when cleaning, the plugin will thereby try to ssh to the target without specifying a key (or any other args) and will fail.
For example:
---8<--- project.properties ---8<---
maven.scp.args=-i /home/jdunn/.ssh/id_dsa_maventest
maven.site.deploy.method=ssh
maven.ssh.args=-i /home/jdunn/.ssh/id_dsa_maventest
maven.username=jdunn
maven.site.deploy.clean=true
---8<--- project.properties ---8<---
where ~/.ssh/id_dsa_maventest is a public/private keypair verified to work interactively, then
% maven site:deploy
.
.
.
site:sshdeploy:
[tar] Building tar: /home/jdunn/devel/platform/target/platform-1.0-site.tar
[gzip] Building: /home/jdunn/devel/platform/target/platform-1.0-site.tar.gz
[delete] Deleting: /home/jdunn/devel/platform/target/platform-1.0-site.tar
[echo] Cleaning destination first
jdunn@host01's password:
jdunn@host01's password: [exec] Permission denied, please try again.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPSITE-24) site:deploy with "clean"
Posted by "Julian Dunn (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPSITE-24?page=comments#action_37978 ]
Julian Dunn commented on MPSITE-24:
-----------------------------------
I think this patch would probably fix it.
--- plugin.jelly.bak 2005-04-22 16:27:06.055396318 -0400
+++ plugin.jelly 2005-04-22 16:28:15.625727301 -0400
@@ -152,7 +152,7 @@
<j:if test="${siteClean}">
<echo>Cleaning destination first</echo>
<exec dir="." executable="${maven.ssh.executable}">
- <arg line="${siteUsername}@${siteAddress} 'rm -r ${siteDirectory}'" />
+ <arg line="${maven.ssh.args} -l ${siteUsername} ${siteAddress} 'rm -r ${siteDirectory}'" />
</exec>
</j:if>
However, my view is that it would be nicer if the "clean" target were able to remove only files that don't exist in the new tarball, so that while the tarball is being pushed over SSH (and if the push fails) then the site doesn't suddenly go AWOL?
> site:deploy with "clean"
> ------------------------
>
> Key: MPSITE-24
> URL: http://jira.codehaus.org/browse/MPSITE-24
> Project: maven-site-plugin
> Type: Bug
> Components: plugin
> Versions: 1.6
> Reporter: Julian Dunn
>
>
> The site:deploy with "clean" (clean target site before deployment) functionality does not respect the args set in maven.ssh.args. This causes problems if the maven.ssh.args property specifies a particular SSH keypair to use; when cleaning, the plugin will thereby try to ssh to the target without specifying a key (or any other args) and will fail.
> For example:
> ---8<--- project.properties ---8<---
> maven.scp.args=-i /home/jdunn/.ssh/id_dsa_maventest
> maven.site.deploy.method=ssh
> maven.ssh.args=-i /home/jdunn/.ssh/id_dsa_maventest
> maven.username=jdunn
> maven.site.deploy.clean=true
> ---8<--- project.properties ---8<---
> where ~/.ssh/id_dsa_maventest is a public/private keypair verified to work interactively, then
> % maven site:deploy
> .
> .
> .
> site:sshdeploy:
> [tar] Building tar: /home/jdunn/devel/platform/target/platform-1.0-site.tar
> [gzip] Building: /home/jdunn/devel/platform/target/platform-1.0-site.tar.gz
> [delete] Deleting: /home/jdunn/devel/platform/target/platform-1.0-site.tar
> [echo] Cleaning destination first
> jdunn@host01's password:
> jdunn@host01's password: [exec] Permission denied, please try again.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPSITE-24) site:deploy with "clean"
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPSITE-24?page=all ]
Lukas Theussl closed MPSITE-24:
-------------------------------
Assign To: Lukas Theussl
Resolution: Fixed
Fix Version: 1.6.2
Fixed, thanks!
The risk about using the clean option is documented on the plugin site.
> site:deploy with "clean"
> ------------------------
>
> Key: MPSITE-24
> URL: http://jira.codehaus.org/browse/MPSITE-24
> Project: maven-site-plugin
> Type: Bug
> Components: plugin
> Versions: 1.6
> Reporter: Julian Dunn
> Assignee: Lukas Theussl
> Fix For: 1.6.2
>
>
> The site:deploy with "clean" (clean target site before deployment) functionality does not respect the args set in maven.ssh.args. This causes problems if the maven.ssh.args property specifies a particular SSH keypair to use; when cleaning, the plugin will thereby try to ssh to the target without specifying a key (or any other args) and will fail.
> For example:
> ---8<--- project.properties ---8<---
> maven.scp.args=-i /home/jdunn/.ssh/id_dsa_maventest
> maven.site.deploy.method=ssh
> maven.ssh.args=-i /home/jdunn/.ssh/id_dsa_maventest
> maven.username=jdunn
> maven.site.deploy.clean=true
> ---8<--- project.properties ---8<---
> where ~/.ssh/id_dsa_maventest is a public/private keypair verified to work interactively, then
> % maven site:deploy
> .
> .
> .
> site:sshdeploy:
> [tar] Building tar: /home/jdunn/devel/platform/target/platform-1.0-site.tar
> [gzip] Building: /home/jdunn/devel/platform/target/platform-1.0-site.tar.gz
> [delete] Deleting: /home/jdunn/devel/platform/target/platform-1.0-site.tar
> [echo] Cleaning destination first
> jdunn@host01's password:
> jdunn@host01's password: [exec] Permission denied, please try again.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org