[D] Table to AG Grid feature parity tracker [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

GitHub user rusackas created a discussion: Table to AG Grid feature parity tracker

AG Grid Table (`plugin-chart-ag-grid-table`) is our newer grid, but the legacy Table viz (`plugin-chart-table`) still does a few things AG Grid doesn't, and I think that's part of what's keeping people on the old one. Opening this to track closing the gap so we can eventually point folks at AG Grid by default and start winding the legacy plugin down.

## Gaps, roughly easiest first

- [ ] `allow_rearrange_columns` control is missing from the panel, even though the wiring (`suppressMovableColumns`) already exists in `useColDefs.ts`. Just needs the control exposed.
- [ ] `allow_render_html` toggle is missing. HTML renders unconditionally in `TextCellRenderer.tsx` right now, so there's no way to opt out. More a controls-parity nit than a real functional gap.
- [ ] Percentage metric calculation control is absent, both the UI control and the buildQuery wiring behind it.
- [ ] Conditional formatting is missing "entire row" highlighting. AG Grid already does per-column `TEXT_COLOR` (`getCellStyle.ts`), and ag-grid supports row-level styling natively via `getRowStyle`, so this should mostly be a control-panel option plus a styling hook, not new infrastructure.
- [ ] Matrixify sections haven't been ported. Curious how much these actually get used before we sink time here, so flagging rather than assuming it's worth doing.
- [ ] Drill-to-detail / cross-filter context menu is the big one. Table wires right-click to build `drillToDetail`/`crossFilter`/`drillBy` filter clauses (`TableChart.tsx`), and AG Grid only has plain row/cell-click cross-filter, nothing on right-click. ag-grid-community doesn't give us a context menu to build on (that's an enterprise feature there), so this one's a bespoke implementation, roughly the shape of what Table already built.

## What AG Grid already does better

Worth keeping in mind so this doesn't read as a pure downgrade: native column resize/reorder/pin, multi-column sort, row grouping/pivot mode, a numbered-row column option, CSV export, and per-column filter popovers (Table only has a single global search box).

## Related

- #27645 (SIP-123), the original AG Grid proposal. Closed, no fine-grained checklist, so not really overlapping with this.
- #38753, a related complaint about AG Grid's column options being harder to find. Also closed.

Planning to work through the list above roughly in order, one PR per item, easy ones first. Flagging here in case anyone's already chipping away at one of these or has thoughts on priority before I start.

GitHub link: https://github.com/apache/superset/discussions/44088

----
This is an automatically sent email for notifications@superset.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@superset.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [D] Table to AG Grid feature parity tracker [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

GitHub user rusackas added a comment to the discussion: Table to AG Grid feature parity tracker

Turns out this list was already being worked on in parallel. #42088 (@michael-s-molina) just merged and closes basically everything above in one PR: drill-to-detail/drill-by, percent-metric calculation mode, entire-row conditional formatting, plus a couple I hadn't even caught (AUTO currency formatting, "Export current view"). It also evaluated Matrixify explicitly and confirmed it's not actually a gap, since Matrixify is disabled for Table V1 too.

That PR also adds a `migrate_viz` CLI path for organizations that want to move existing `table` charts to `ag-grid-table` on their own schedule. No automatic DB migration yet, deliberately, since V2's still `IN DEVELOPMENT` behind `AG_GRID_TABLE_ENABLED`.

I don't think there's anything left on the original list worth a PR for. Leaving this open for a bit in case anyone spots something I missed, otherwise I'll close it out.

GitHub link: https://github.com/apache/superset/discussions/44088#discussioncomment-18371932

----
This is an automatically sent email for notifications@superset.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@superset.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [D] Table to AG Grid feature parity tracker [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

GitHub user rusackas added a comment to the discussion: Table to AG Grid feature parity tracker

Found one more actual gap while poking at this: v1 always renders striped rows, v2 doesn't by default. Opened #44112 for it.

GitHub link: https://github.com/apache/superset/discussions/44088#discussioncomment-18374216

----
This is an automatically sent email for notifications@superset.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@superset.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org