You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by remibergsma <gi...@git.apache.org> on 2016/04/30 20:38:48 UTC
[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1524
KVM: Fix plugging ip addresses to the wrong interface
Fix for KVM, where the public ip would be added to the guest network. Reason is because it used 'broadcastUrl' as an index, which turned out not to be unique in all cases and was overwritten. This resulted in the public ip address being added to the wrong interface (see screenshots).
Problem:
After patch:
The `192.168.23.0/24` range is used as 'public' in this lab.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/remibergsma/cloudstack fix/libvirt-interfaces
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1524.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1524
----
commit 4f3b0f56cbb9e1e16182109c797fcceff578d7ea
Author: Remi Bergsma <gi...@remi.nl>
Date: 2016-04-30T18:13:44Z
KVM: Fix plugging ip addresses to the wrong interface
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1524
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...
Posted by kiwiflyer <gi...@git.apache.org>.
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1524#issuecomment-215986875
Strangely enough, I just ran into this problem yesterday.I'll pull it in. Thanks Remi!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1524#issuecomment-216064935
@kiwiflyer Sorry but this seems to have issues. We run this in prod with Cosmic but apparently some other patch is missing here in order for this to work properly. Unfortunately I have no more time to work on this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1524#issuecomment-216030504
Force pushed a final time, else I give up on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1524#issuecomment-216030450
This time around Jenkins is happy and Travis times out :-s
```
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1524#issuecomment-216336787
this does not work for me as well.
If there are multiple public interfaces in the VR, only the last one works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1524#issuecomment-215991817
Jenkins error says: `Unable to instrument project`, seems like a workspace issue or such.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---