You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/07/08 16:31:00 UTC

[GitHub] [drill] Leon-WTF opened a new pull request #2225: DRILL-7922: Add feature of viewing external profile in web UI

Leon-WTF opened a new pull request #2225:
URL: https://github.com/apache/drill/pull/2225


   # [DRILL-7922](https://issues.apache.org/jira/browse/DRILL-7922): Add import profile function
   
   ## Description
   Usage scenario:
   Analysis the profile json exported from other clusters(ex. user's cluster). The original profile json is not readable (time type is epoch time), so it will be better to view it in the detailed profile web console.
   
   ## Documentation
   To upload the profile json file(need to be the same format as the json profile exported from the detailed profile web console) and view it on the web console:
   - click import button on the Profiles tab of Web-UI
   ![image](https://user-images.githubusercontent.com/25920008/118363081-46721b00-b5c5-11eb-99a0-ec48c460b2e7.png)
   - select the profile file you want to view
   ![image](https://user-images.githubusercontent.com/25920008/118351326-f4fa6980-b58d-11eb-8aff-eb1ea346fd7f.png)
   - the profile will be displayed as nomal query profile
   ![image](https://user-images.githubusercontent.com/25920008/118351355-1b200980-b58e-11eb-9ebd-934c619b1222.png)
   
   ## Testing
   NA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] Leon-WTF commented on pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
Leon-WTF commented on pull request #2225:
URL: https://github.com/apache/drill/pull/2225#issuecomment-841612286


   > @Leon-WTF
   > Thanks for the contribution! Can you please explain the purpose or use case for this PR?
   
   Added in the PR description, is that clear for you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #2225: DRILL-7922: Add feature of viewing external profile in web UI

Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2225:
URL: https://github.com/apache/drill/pull/2225#issuecomment-876542274


   @Leon-WTF Why did you close the PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] Leon-WTF commented on a change in pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
Leon-WTF commented on a change in pull request #2225:
URL: https://github.com/apache/drill/pull/2225#discussion_r642897014



##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
##########
@@ -395,6 +410,33 @@ public Viewable getProfile(@PathParam("queryid") String queryId){
     }
   }
 
+  @POST
+  @Path("/profiles/view")
+  @Consumes(MediaType.MULTIPART_FORM_DATA)
+  @Produces(MediaType.TEXT_HTML)
+  public Viewable viewProfile(@FormDataParam(PROFILE_DATA) String content,
+                              @Context HttpServletRequest req){
+    try {
+      HttpSession session = req.getSession(true);
+      if (session.isNew()) {
+        session.setMaxInactiveInterval(work.getContext().getConfig()
+          .getInt(ExecConstants.HTTP_SESSION_MAX_IDLE_SECS));
+      }
+      session.setAttribute(PROFILE_DATA, content);

Review comment:
       same as above

##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
##########
@@ -373,9 +379,18 @@ private QueryProfile getQueryProfile(String queryId) {
   @GET
   @Path("/profiles/{queryid}.json")
   @Produces(MediaType.APPLICATION_JSON)
-  public String getProfileJSON(@PathParam("queryid") String queryId) {
+  public String getProfileJSON(@PathParam("queryid") String queryId,
+                               @Context HttpServletRequest req) {
     try {
-      return new String(work.getContext().getProfileStoreContext().getProfileStoreConfig().getSerializer().serialize(getQueryProfile(queryId)));
+      HttpSession session = req.getSession(false);
+      if (session == null || session.getAttribute(PROFILE_DATA) == null) {

Review comment:
       if drill.exec.security.user.auth.enabled=false, session will be null




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] luocooong commented on a change in pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
luocooong commented on a change in pull request #2225:
URL: https://github.com/apache/drill/pull/2225#discussion_r642077253



##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServerConstants.java
##########
@@ -45,4 +45,7 @@ private WebServerConstants() {}
 
   // Name of the CSRF protection token attribute
   public static final String CSRF_TOKEN = "csrfToken";
+
+  // Key of the profile data to view
+  public static final String PROFILE_DATA = "profile_data";

Review comment:
       Good define.

##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebUtils.java
##########
@@ -55,7 +55,10 @@
   public static String getCsrfTokenFromHttpRequest(HttpServletRequest request) {
     // No need to create a session if not present (i.e. if a user is logged in)
     HttpSession session = request.getSession(false);
-    return session == null ? "" : (String) session.getAttribute(WebServerConstants.CSRF_TOKEN);
+    String res = session == null ? "" :
+      (String) session.getAttribute(WebServerConstants.CSRF_TOKEN);
+    // In case session is created when authentication is disabled
+    return res == null ? "" : res;

Review comment:
       What happens without these changes? Is it possible to revert these if no effect for anything?

##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
##########
@@ -373,9 +379,18 @@ private QueryProfile getQueryProfile(String queryId) {
   @GET
   @Path("/profiles/{queryid}.json")
   @Produces(MediaType.APPLICATION_JSON)
-  public String getProfileJSON(@PathParam("queryid") String queryId) {
+  public String getProfileJSON(@PathParam("queryid") String queryId,
+                               @Context HttpServletRequest req) {
     try {
-      return new String(work.getContext().getProfileStoreContext().getProfileStoreConfig().getSerializer().serialize(getQueryProfile(queryId)));
+      HttpSession session = req.getSession(false);
+      if (session == null || session.getAttribute(PROFILE_DATA) == null) {

Review comment:
       I think this session is not null here, because the `Cookie: JSESSIONID` is not null at this time. I recommend that :
   ```java
   if(req.getSession().getAttribute(PROFILE_DATA) == null) { }
   ```

##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
##########
@@ -395,6 +410,33 @@ public Viewable getProfile(@PathParam("queryid") String queryId){
     }
   }
 
+  @POST
+  @Path("/profiles/view")
+  @Consumes(MediaType.MULTIPART_FORM_DATA)
+  @Produces(MediaType.TEXT_HTML)
+  public Viewable viewProfile(@FormDataParam(PROFILE_DATA) String content,
+                              @Context HttpServletRequest req){
+    try {
+      HttpSession session = req.getSession(true);
+      if (session.isNew()) {
+        session.setMaxInactiveInterval(work.getContext().getConfig()
+          .getInt(ExecConstants.HTTP_SESSION_MAX_IDLE_SECS));
+      }
+      session.setAttribute(PROFILE_DATA, content);

Review comment:
       As the above said, I recommend that :
   ```java
   req.getSession().setAttribute(PROFILE_DATA, content)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] Leon-WTF commented on pull request #2225: DRILL-7922: Add feature of viewing external profile in web UI

Posted by GitBox <gi...@apache.org>.
Leon-WTF commented on pull request #2225:
URL: https://github.com/apache/drill/pull/2225#issuecomment-876554369


   > @Leon-WTF Why did you close the PR?
   
   this PR close automaticlly when I reset this branch to master, I re-commit the changes to this branch, could you please help to re-open this PR? thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] Leon-WTF commented on pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
Leon-WTF commented on pull request #2225:
URL: https://github.com/apache/drill/pull/2225#issuecomment-846521358


   > @Leon-WTF Hello. I want to report an issue with open a profile json (from another cluster) :
   > 
   > 1. Cannot review the "Virtualized Plan" (It's blank)
   > 2. And the "Elapsed Timeline" (It's also blank)
   > 
   > There is my [profile json](https://github.com/apache/drill/files/6508462/test.txt)
   
   Thanks for reporting, I have fixed it. Please have a try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] luocooong commented on pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2225:
URL: https://github.com/apache/drill/pull/2225#issuecomment-874845845


   @Leon-WTF Good. We can also revert the change in `WebServerConstants`. And the checkstyle failed on CI. Then, Could you please squash all the commits (rebase on master)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] Leon-WTF commented on pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
Leon-WTF commented on pull request #2225:
URL: https://github.com/apache/drill/pull/2225#issuecomment-874817786


   > @Leon-WTF This feature should be used for troubleshooting. I chose to keep the code simple.
   
   Got it, I have modified the code to base on cache, please have a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] Leon-WTF commented on a change in pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
Leon-WTF commented on a change in pull request #2225:
URL: https://github.com/apache/drill/pull/2225#discussion_r642895394



##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebUtils.java
##########
@@ -55,7 +55,10 @@
   public static String getCsrfTokenFromHttpRequest(HttpServletRequest request) {
     // No need to create a session if not present (i.e. if a user is logged in)
     HttpSession session = request.getSession(false);
-    return session == null ? "" : (String) session.getAttribute(WebServerConstants.CSRF_TOKEN);
+    String res = session == null ? "" :
+      (String) session.getAttribute(WebServerConstants.CSRF_TOKEN);
+    // In case session is created when authentication is disabled
+    return res == null ? "" : res;

Review comment:
       if drill.exec.security.user.auth.enabled=false, WebServerConstants.CSRF_TOKEN attribute will not be added into the session, after I created the session, this function will return null, which will cause exception when rendering the profile page




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] Leon-WTF commented on pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
Leon-WTF commented on pull request #2225:
URL: https://github.com/apache/drill/pull/2225#issuecomment-874750796


   Thanks congļ¼Œjust if we use queryId as the cache key, it may conflict when two users upload different profile jsons with same query id at the same time(Though this may be a rare condition). What do you think?
   
   > @Leon-WTF Hi. I think we made things complicated. There is a suggestion to revise :
   > 
   > 1. Define the cache above the `getProfileJSON(@PathParam("queryid") String queryId)`
   > 
   > ```java
   >   // provide cache for view the profile
   >   private static final Cache<String, String> PROFILE_CACHE =
   >       CacheBuilder
   >         .newBuilder()
   >           .expireAfterAccess(1, TimeUnit.MINUTES)
   >             .build();
   > ```
   > 
   > 1. Add the if-else in the `getProfileJSON(@PathParam("queryid") String queryId)`
   > 
   > ```java
   > String content = PROFILE_CACHE.getIfPresent(queryId);
   > if (content == null) {
   >  // return the new
   > } else {
   >   PROFILE_CACHE.invalidate(queryId);
   >   // then, return the cache
   > }
   > ```
   > 
   > 1. Cache the data in the `viewProfile(@FormDataParam(PROFILE_DATA) String content)`
   > 
   > ```java
   > PROFILE_CACHE.put(profile.getQueryId(), content);
   > ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] Leon-WTF commented on a change in pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
Leon-WTF commented on a change in pull request #2225:
URL: https://github.com/apache/drill/pull/2225#discussion_r642895394



##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebUtils.java
##########
@@ -55,7 +55,10 @@
   public static String getCsrfTokenFromHttpRequest(HttpServletRequest request) {
     // No need to create a session if not present (i.e. if a user is logged in)
     HttpSession session = request.getSession(false);
-    return session == null ? "" : (String) session.getAttribute(WebServerConstants.CSRF_TOKEN);
+    String res = session == null ? "" :
+      (String) session.getAttribute(WebServerConstants.CSRF_TOKEN);
+    // In case session is created when authentication is disabled
+    return res == null ? "" : res;

Review comment:
       if drill.exec.security.user.auth.enabled=false, WebServerConstants.CSRF_TOKEN attribute will not be added into the session, after I created the session, this function will return null, which will cause exception when rending the profile page




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] Leon-WTF commented on pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
Leon-WTF commented on pull request #2225:
URL: https://github.com/apache/drill/pull/2225#issuecomment-876376398


   > @Leon-WTF Don't forget the test, thanks.
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] Leon-WTF commented on pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
Leon-WTF commented on pull request #2225:
URL: https://github.com/apache/drill/pull/2225#issuecomment-841612331


   > @Leon-WTF Thanks for your contribution. Could you please upload screenshots for the web console?
   
   Added in the PR description, is that ok?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] luocooong commented on pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2225:
URL: https://github.com/apache/drill/pull/2225#issuecomment-840628547


   @Leon-WTF Thanks for your contribution. Could you please upload screenshots for the web console?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2225:
URL: https://github.com/apache/drill/pull/2225#issuecomment-840627985


   @Leon-WTF 
   Thanks for the contribution!  Can you please explain the purpose or use case for this PR? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] luocooong commented on pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2225:
URL: https://github.com/apache/drill/pull/2225#issuecomment-874760720


   @Leon-WTF This feature should be used for troubleshooting. I chose to keep the code simple.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] luocooong commented on pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2225:
URL: https://github.com/apache/drill/pull/2225#issuecomment-844042861


   @Leon-WTF Hello. I want to report an issue with open a profile json (from another cluster) :
   1. Cannot review the "Virtualized Plan" (It's blank)
   2. And the "Elapsed Timeline" (It's also blank)
   
   There is my  [profile json](https://github.com/apache/drill/files/6508462/test.txt)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] luocooong commented on a change in pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
luocooong commented on a change in pull request #2225:
URL: https://github.com/apache/drill/pull/2225#discussion_r638889212



##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
##########
@@ -83,6 +86,8 @@
   @Inject
   HttpServletRequest request;
 
+  static String importedProfile = null;

Review comment:
       We are using a variable to store the profile and avoid loading the profile from disk, that's good. But how to do that if multiple users use the function at the same time...

##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
##########
@@ -395,6 +406,22 @@ public Viewable getProfile(@PathParam("queryid") String queryId){
     }
   }
 
+  @POST
+  @Path("/profiles/view")
+  @Consumes(MediaType.MULTIPART_FORM_DATA)
+  @Produces(MediaType.TEXT_HTML)
+  public Viewable viewProfile(@FormDataParam("profileFile") String content){

Review comment:
       It is possible to rename the "profileFile" to "profile_object" or "profile_data" ... ?

##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
##########
@@ -395,6 +406,22 @@ public Viewable getProfile(@PathParam("queryid") String queryId){
     }
   }
 
+  @POST
+  @Path("/profiles/view")

Review comment:
       Good naming : `view`, not the `import`. Could you please rename all names related to the "import" to "view" ?

##########
File path: exec/java-exec/src/main/resources/rest/profile/list.ftl
##########
@@ -84,6 +84,13 @@
         $("#queryCancelModal").modal("show");
     }
 
+    function uploadProfile() {

Review comment:
       Add a comment above the function.

##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
##########
@@ -395,6 +406,22 @@ public Viewable getProfile(@PathParam("queryid") String queryId){
     }
   }
 
+  @POST
+  @Path("/profiles/view")
+  @Consumes(MediaType.MULTIPART_FORM_DATA)
+  @Produces(MediaType.TEXT_HTML)
+  public Viewable viewProfile(@FormDataParam("profileFile") String content){
+    try {
+      importedProfile = content;
+      QueryProfile profile = work.getContext().getProfileStoreContext().getProfileStoreConfig().getSerializer().deserialize(content.getBytes());
+      ProfileWrapper wrapper = new ProfileWrapper(profile, work.getContext().getConfig(), request);
+      return ViewableWithPermissions.create(authEnabled.get(), "/rest/profile/profile.ftl", sc, wrapper);
+    } catch (Exception | Error e) {
+      logger.error("Exception was thrown when parsing profile {}:\n{}", content, e);

Review comment:
       Add a space between the "profile {}" and ":".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] luocooong commented on pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2225:
URL: https://github.com/apache/drill/pull/2225#issuecomment-874858488


   @Leon-WTF Don't forget the test, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] Leon-WTF commented on pull request #2225: DRILL-7922: Add feature of viewing external profile in web UI

Posted by GitBox <gi...@apache.org>.
Leon-WTF commented on pull request #2225:
URL: https://github.com/apache/drill/pull/2225#issuecomment-876545499


   > @Leon-WTF Why did you close the PR?
   
   something wrong with git, i'am trying to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] Leon-WTF commented on pull request #2225: DRILL-7922: Add import profile function

Posted by GitBox <gi...@apache.org>.
Leon-WTF commented on pull request #2225:
URL: https://github.com/apache/drill/pull/2225#issuecomment-874853811


   > @Leon-WTF Good. We can also revert the change in `WebServerConstants`. And the checkstyle failed on CI. Then, Could you please squash all the commits (rebase on master)?
   
   done, if you have no more comments, I will squash the commits after CI passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] luocooong merged pull request #2225: DRILL-7922: Add feature of viewing external profile in web UI

Posted by GitBox <gi...@apache.org>.
luocooong merged pull request #2225:
URL: https://github.com/apache/drill/pull/2225


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] Leon-WTF closed pull request #2225: DRILL-7922: Add feature of viewing external profile in web UI

Posted by GitBox <gi...@apache.org>.
Leon-WTF closed pull request #2225:
URL: https://github.com/apache/drill/pull/2225


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org