You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampipes.apache.org by "dominikriemer (via GitHub)" <gi...@apache.org> on 2023/03/27 07:55:18 UTC

[I] Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations (streampipes)

dominikriemer opened a new issue, #1458:
URL: https://github.com/apache/streampipes/issues/1458

   ### Body
   
   Currently, the HTTP connectors only support very basic user-defined parameters. Users should be able to add custom headers, e.g., for providing authentication options.
   
   ### StreamPipes Committer
   
   I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations

Posted by "debanjanc01 (via GitHub)" <gi...@apache.org>.
debanjanc01 commented on issue #1458:
URL: https://github.com/apache/streampipes/issues/1458#issuecomment-1747029985

   Hi @dominikriemer @bossenti 
   While I've gone through the comments on this issue and the discussion on [1450](https://github.com/apache/streampipes/discussions/1450) I'm unable to find the entry points/classes that need change. 
   Are we just talking about the `HttpStreamProtocol.java` as mentioned in [#1450](https://github.com/apache/streampipes/discussions/1450)?
   
   Still figuring my way around the codebase. 👨‍💻 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations

Posted by "debanjanc01 (via GitHub)" <gi...@apache.org>.
debanjanc01 commented on issue #1458:
URL: https://github.com/apache/streampipes/issues/1458#issuecomment-1746229267

   Please assign this to me. I'll give a go at it @bossenti 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations

Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1458:
URL: https://github.com/apache/streampipes/issues/1458#issuecomment-1746202632

   Yes, it is still open and we would be happy if take this up 🙂 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations

Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer commented on issue #1458:
URL: https://github.com/apache/streampipes/issues/1458#issuecomment-1748456551

   HI @debanjanc01 so the idea is that users can provide custom key/value pairs for the HTTP headers. 
   
   You could think of the following structure for the UI element:
   A static property collection (which will display a list of the children assigned to the component) with one static property group, which contains two free text properties for the key and the value. The group can be configured to display the children horizontally.
   
   Hope this helps!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations (streampipes)

Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer commented on issue #1458:
URL: https://github.com/apache/streampipes/issues/1458#issuecomment-1485076763

   Hi @CVamsi27 and welcome! Have you already set up a StreamPipes dev system?
   I would suggest to start with the sink and continue with the adapter afterwards.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations (streampipes)

Posted by "CVamsi27 (via GitHub)" <gi...@apache.org>.
CVamsi27 commented on issue #1458:
URL: https://github.com/apache/streampipes/issues/1458#issuecomment-1485198600

   I haven't set up StreamPipes system yet. I will set it up now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations (streampipes)

Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on issue #1458:
URL: https://github.com/apache/streampipes/issues/1458#issuecomment-1488029861

   Hi @CVamsi27 since you liked the comment of @purplesmurf45 I assume that you are not working on it, right?
   
   @purplesmurf45 thanks a lot, I'll asign you the issue. Let us know if you have any questions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations (streampipes)

Posted by "CVamsi27 (via GitHub)" <gi...@apache.org>.
CVamsi27 commented on issue #1458:
URL: https://github.com/apache/streampipes/issues/1458#issuecomment-1484826932

   Hello, I would like to work on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations

Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1458:
URL: https://github.com/apache/streampipes/issues/1458#issuecomment-1748115193

   @debanjanc01 yes we are talking about this class
   
   The aim is to extend the configuration of this adapter by a group of additional HTTP headers.
   This could be solved with a similar UI element as for the [S7 adapter](https://github.com/apache/streampipes/blob/dev/streampipes-extensions/streampipes-connect-adapters-iiot/src/main/java/org/apache/streampipes/connect/iiot/adapters/plc4x/s7/Plc4xS7Adapter.java)
   
   This is just meant to be an inspiration, column names etc. would need to be adjusted 🙂 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations

Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe closed issue #1458: Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations
URL: https://github.com/apache/streampipes/issues/1458


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations (streampipes)

Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer commented on issue #1458:
URL: https://github.com/apache/streampipes/issues/1458#issuecomment-1488449783

   @purplesmurf45 The goal would be to let users provided custom HTTP headers (see a brief discussion at #1450 ).
   Headers are typically key/value pairs. So we could add an optional configuration option to assign a list of these key/value pairs which would then be used for reading/writing from/to the HTTP endpoint.
   One example would be Authentication headers (such as Bearer Tokens), provision of content types or any other HTTP header. E.g., in a future extension, we could add a feature to the REST controller to send events in different formats such as JSON or YAML.
   The Apache HTTP fluent library which is used in the `RestPublisher` provides several convenience methods to add headers to a request. These would be read from the user-provided configuration. E.g., we could have a `CollectionStaticProperty` with a group of key/value pairs.
   Hope this helps!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations (streampipes)

Posted by "purplesmurf45 (via GitHub)" <gi...@apache.org>.
purplesmurf45 commented on issue #1458:
URL: https://github.com/apache/streampipes/issues/1458#issuecomment-1488361231

   Thanks @tenthe @dominikriemer! If you could share any resources regarding custom header implementations, that would be really helpful 🙂


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations (streampipes)

Posted by "neethakorem (via GitHub)" <gi...@apache.org>.
neethakorem commented on issue #1458:
URL: https://github.com/apache/streampipes/issues/1458#issuecomment-1488357279

   Thanks, @tenthe @dominikriemer! If you could you share any resources regarding custom header implementations or such, that would be really helpful..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations

Posted by "debanjanc01 (via GitHub)" <gi...@apache.org>.
debanjanc01 commented on issue #1458:
URL: https://github.com/apache/streampipes/issues/1458#issuecomment-1745595196

   Hi @dominikriemer , is this still open? I can take this up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support custom HTTP headers in `HTTPStreamAdapter` and `RestController` configurations (streampipes)

Posted by "purplesmurf45 (via GitHub)" <gi...@apache.org>.
purplesmurf45 commented on issue #1458:
URL: https://github.com/apache/streampipes/issues/1458#issuecomment-1487940155

   Hello @dominikriemer, is this issue up for grabs? If so, can you assign it to me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org