You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/14 02:05:41 UTC
[GitHub] [kylin] zhoukangcn commented on a change in pull request #1059:
KYLIN-4291 Parallel segment building may causes WriteConflictException
zhoukangcn commented on a change in pull request #1059: KYLIN-4291 Parallel segment building may causes WriteConflictException
URL: https://github.com/apache/kylin/pull/1059#discussion_r366121753
##########
File path: core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryManager.java
##########
@@ -193,12 +194,24 @@ private DictionaryInfo updateExistingDictLastModifiedTime(String dictPath) throw
ResourceStore store = getStore();
if (StringUtils.isBlank(dictPath))
return NONE_INDICATOR;
- long now = System.currentTimeMillis();
- store.updateTimestamp(dictPath, now);
- logger.info("Update dictionary {} lastModifiedTime to {}", dictPath, now);
- DictionaryInfo dictInfo = load(dictPath, true);
- updateDictCache(dictInfo);
- return dictInfo;
+
+ int retry = 7;
Review comment:
I think change constant to KylinConfig is a better way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services