You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/05 05:31:27 UTC

[GitHub] [spark] dongjoon-hyun opened a new pull request, #38909: [SPARK-41385][K8S] Replace deprecated `.newInstance()` in K8s module

dongjoon-hyun opened a new pull request, #38909:
URL: https://github.com/apache/spark/pull/38909

   ### What changes were proposed in this pull request?
   
   This PR aims to replace the deprecated `Class.newInstance` with `Class.getConstructor.newInstance`.
   
   ### Why are the changes needed?
   
   SPARK-25984 and SPARK-28063 removed these instances before.
   
   SPARK-37145 introduced these new instances at 3.3.0.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Pass the CIs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #38909: [SPARK-41385][K8S] Replace deprecated `.newInstance()` in K8s module

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38909:
URL: https://github.com/apache/spark/pull/38909#issuecomment-1336810296

   All tests (except documentation generation) are finished. This PR is irrelevant to the doc generation.
   Merged to master/3.3.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #38909: [SPARK-41385][K8S] Replace deprecated `.newInstance()` in K8s module

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38909:
URL: https://github.com/apache/spark/pull/38909#issuecomment-1336784356

   Could you review this, @Yikun ? I missed this at SPARK-37145.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #38909: [SPARK-41385][K8S] Replace deprecated `.newInstance()` in K8s module

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38909:
URL: https://github.com/apache/spark/pull/38909#issuecomment-1336800566

   Thank you for review and approval, @Yikun .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #38909: [SPARK-41385][K8S] Replace deprecated `.newInstance()` in K8s module

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #38909: [SPARK-41385][K8S] Replace deprecated `.newInstance()` in K8s module
URL: https://github.com/apache/spark/pull/38909


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org