[jira] [Comment Edited] (OFBIZ-3764) Storing supplier relationship sub-class & two related fixes

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-3764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273742#comment-14273742 ] 

Jacques Le Roux edited comment on OFBIZ-3764 at 1/12/15 4:33 PM:
-----------------------------------------------------------------

I had a new look and was interested by [~adrianc@hlmksw.com]'s comment:
{quote}
We have similar needs here with parties in other relationships. Our
dealers have dealer numbers and license numbers, our suppliers give us
numbers (the same as the previous thread), and the homeowners have a
customer number and other bits of information we have to maintain for them.
{quote}

Taking Adrian's comment into account I think the proposed data model is good but it needs to be generaliseds since experience shows that not only suppliers are concerned but other party types as well
The names of the new entities should be changed from 
* SupplierRel to PartyRelAccount
* SupplierRelAndPartyRelationship to PartyRelAccountAndPartyRelationship
and those entities moved from 
package-name="org.ofbiz.product.supplier"
to package-name="org.ofbiz.party.party"
Of course the description should be also updated

The rest sounds good to me. If nobody see a problem with that I will commit a slightly modified patch soon (yes it still applies)


was (Author: jacques.le.roux):
I had a new look and was interested by [~adrianc@hlmksw.com]'s comment:
{quote}
We have similar needs here with parties in other relationships. Our
dealers have dealer numbers and license numbers, our suppliers give us
numbers (the same as the previous thread), and the homeowners have a
customer number and other bits of information we have to maintain for them.
{quote}

Taking Adrian's comment into account I think the proposed data model is good but it needs to be generaliseds since experience shows that not only suppliers are concerned but other party types as well
The names of the new entities should be changed from 
* SupplierRel to PartyRelAccount
* SupplierRelAndPartyRelationship to PartyRelAccountAndPartyRelationship
and those entiey moved from 
package-name="org.ofbiz.product.supplier"
to package-name="org.ofbiz.party.party"
Of course the description should be also updated

The rest sounds good to me. If nobody see a problem with that I will commit a slightly modified patch soon (yes it still applies)

> Storing supplier relationship sub-class & two related fixes
> -----------------------------------------------------------
>
>                 Key: OFBIZ-3764
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3764
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party, product
>            Reporter: Bob Morley
>         Attachments: OFBIZ-3764_SupplierRel.patch
>
>
> Despite how much I typed; this is really a very small patch.  :)
> This patch adds a new entity "SupplierRel" which is a sub-class of "PartyRelationship" (as well as a view-entity for convenience).  It provides a new field "accountNumber" that can be used to store the long-term account number assigned to the relationship between the Company and its Supplier.  The life of this account number is longer than any agreement between the two, so it has been put on this informal relationship.  Moreover, it is possible to have an informal relationship between a company and a supplier with out an explicit binding agreement -- this was discussed most recently in this thread:
> http://ofbiz.135035.n4.nabble.com/Storing-supplier-provided-account-number-td2076162.html#a2076162
> ALSO -- this patch fixes two problems that I encountered when attempting to create a party relationship.
> a) It did not look right to have an empty dropdown for status -- I created the standard "Created" status under the PARTY_REL_STATUS type so that we show the only applicable status.  There does not appear to be any specific logic looking for party relationships with a blank status, so creating ones with this status should not cause any issues.
> b) When creating the PartyRelationship the response in the controller was of type "view-last" which was a problem because the last controller request was typically the ajax one to "FindPartyName" which was used as part of the party lookup field in that form.  The net result, was that on success it would render the PartyName instead of replaying the EditPartyRelationships.  Changed form "view-last" to "view" to resolve this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)