You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/22 18:29:20 UTC

[GitHub] [airflow] ReadytoRocc opened a new issue #20468: Need to set `tags=[]` to remove all tags from a DAG.

ReadytoRocc opened a new issue #20468:
URL: https://github.com/apache/airflow/issues/20468


   ### Apache Airflow version
   
   2.2.3 (latest released)
   
   ### What happened
   
   When removing the `tags` argument from a DAG, the tags are not removed. You need to set `tags=[]` to remove them.
   
   ### What you expected to happen
   
   I would expect that if you remove the `tags` argument from the `DAG` definition, all tags would be removed from the DAG.
   
   ### How to reproduce
   
   Add `tags=["foo"]` to your `DAG` definition, and then remove the argument entirely. The `DAG` should still have tag `foo` in the UI. You should see the tag removed once you set `tags=[]`.
   
   ### Operating System
   
   Debian GNU/Linux 11 (bullseye)
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Other Docker-based deployment
   
   ### Deployment details
   
   Astronomer CLI Docker based deployment.
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk closed issue #20468: Need to set `tags=[]` to remove all tags from a DAG.

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #20468:
URL: https://github.com/apache/airflow/issues/20468


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ReadytoRocc commented on issue #20468: Need to set `tags=[]` to remove all tags from a DAG.

Posted by GitBox <gi...@apache.org>.
ReadytoRocc commented on issue #20468:
URL: https://github.com/apache/airflow/issues/20468#issuecomment-1000388343


   @PApostol @potiuk confirmed that this is working as expected on `main`. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #20468: Need to set `tags=[]` to remove all tags from a DAG.

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #20468:
URL: https://github.com/apache/airflow/issues/20468#issuecomment-1000352701


   Oh yeah. Some nice side-effect of Our #19891  quest with MyPY.
   
   It's been fixed here: 
   
   https://github.com/apache/airflow/pull/20272 
   
   @ReadytoRocc - I am closing the issue now - but if you could double-check if it is really fixed, it would be great.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #20468: Need to set `tags=[]` to remove all tags from a DAG.

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #20468:
URL: https://github.com/apache/airflow/issues/20468#issuecomment-1000390604


   > @PApostol @potiuk confirmed that this is working as expected on `main`. Thanks!
   
   Glad to hear! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on issue #20468: Need to set `tags=[]` to remove all tags from a DAG.

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #20468:
URL: https://github.com/apache/airflow/issues/20468#issuecomment-1000352701


   Oh yeah. Some nice side-effect of Our #19891  quest with MyPY.
   
   It's been fixed here: 
   
   https://github.com/apache/airflow/pull/20272 
   
   @ReadytoRocc - I am closing the issue now - but if you could double-check if it is really fixed, it would be great.
   
   (we can always re-open the issue if you find it's not fixed).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] PApostol commented on issue #20468: Need to set `tags=[]` to remove all tags from a DAG.

Posted by GitBox <gi...@apache.org>.
PApostol commented on issue #20468:
URL: https://github.com/apache/airflow/issues/20468#issuecomment-999847126


   I think this has already been fixed on `main` by changing `self.tags = tags` to `self.tags = tags or []` in [airflow/models/dag.py](https://github.com/apache/airflow/blob/main/airflow/models/dag.py#L492) (the change is not in Airflow 2.2.3 though). Can you check the issue against `main`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org