[GitHub] [spark] amaliujia commented on a diff in pull request #40041: [SPARK-42453][CONNECT] Implement function max in Scala client

["amaliujia (via GitHub)" <gi...@apache.org>]

amaliujia commented on code in PR #40041:
URL: https://github.com/apache/spark/pull/40041#discussion_r1107570493


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -44,6 +44,28 @@ object functions {
    */
   def col(colName: String): Column = Column(colName)
 
+
+  /**
+   * Aggregate function: returns the maximum value of the expression in a group.
+   *
+   * @group agg_funcs
+   * @since 3.4.0
+   */
+  def max(e: Column): Column = withUnresolvedFunction("max", e.expr)
+
+  private def withUnresolvedFunction(
+      funcName: String,
+      expr: proto.Expression,
+      isDistinct: Boolean = false): Column = {
+    Column { builder =>
+      val funcBuilder = proto.Expression.UnresolvedFunction.newBuilder()
+      funcBuilder.setFunctionName(funcName)
+      funcBuilder.addArguments(expr)
+      funcBuilder.setIsDistinct(isDistinct)
+      builder.setUnresolvedFunction(funcBuilder)

Review Comment:
   This becomes unused to remove.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org