You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2026/10/05 06:57:52 UTC
Re: [PR] Bump the opentelemetry group across 1 directory with 7 updates [spark-connect-gateway]
viirya commented on PR #41:
URL: https://github.com/apache/spark-connect-gateway/pull/41#issuecomment-5989649664
Superseded by #43 (SPARK-59973), which applies the same upgrade — the six
`opentelemetry*` crates to 0.33 and `tracing-opentelemetry` to 0.34.
Worth saying that this PR was raised *correctly*: the grouping added in
SPARK-59550 did its job, so this arrived as one coherent group rather than the
seven individually unmergeable single-crate PRs that preceded it (#8 being the
example). The edges behaved too — `tracing-opentelemetry` was grouped in, while
`tracing` and `tracing-subscriber` were correctly left out.
Closing only because this branch was cut before the proto work on `main` (#40,
#42) landed, so the diff as filed carries that older base. The upgrade itself
checked out and is verified in #43: the lockfile resolves a single
`opentelemetry`, `tracing_emits_spans_and_propagates_traceparent` passes, and the
full workspace is 204 tests green.
Thanks, dependabot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org