[GitHub] [airflow] yuqian90 edited a comment on issue #7276: [AIRFLOW-5391] Do not run skipped tasks when they are cleared

[GitBox <gi...@apache.org>]

yuqian90 edited a comment on issue #7276: [AIRFLOW-5391] Do not run skipped tasks when they are cleared
URL: https://github.com/apache/airflow/pull/7276#issuecomment-586576551
 
 
   Hi @ashb  thanks for you review. I have adopted all your suggestions, with this tweak:
   
   - I moved the XCom code into ``SkipMixin``. The main use of this ``BranchPythonOperator`` and ``BaseBranchOperator`` both determine tasks to skip by returning branches to **follow**. So I find it important to have ``SkipMixin`` store the branches **followed** rather than the ones skipped when ``skip_all_except()`` is called. When ``skip()`` is called, obviously it should store the tasks that are skipped. So the re-vamped ``SkipMixin`` now handles both cases. The shared code is refactored into ``_set_state_to_skipped()`` to avoid duplication.
   
   Please take another look and let me know what you think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services