You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by "Roger Hoover (JIRA)" <ji...@apache.org> on 2015/10/27 05:56:27 UTC

[jira] [Created] (SAMZA-801) MetricsSnapshotReporter cannot tolerate errors

Roger Hoover created SAMZA-801:
----------------------------------

             Summary: MetricsSnapshotReporter cannot tolerate errors 
                 Key: SAMZA-801
                 URL: https://issues.apache.org/jira/browse/SAMZA-801
             Project: Samza
          Issue Type: Bug
          Components: metrics
    Affects Versions: 0.9.1
            Reporter: Roger Hoover


If an error occurs in MetricsSnapshotReporter.run(), it does not get logged anywhere and Executor.scheduleWithFixedDelay() will not reschedule it.  The effect is that metrics stop being sent to the metrics topic.

There should be a try/catch in MetricsSnapshotReporter.run() which logs errors and suppresses them to that the thread still had a chance to run again.

I ran into this by creating a custom metric (https://github.com/Quantiply/rico/blob/master/core/src/main/java/com/quantiply/samza/metrics/WindowedMapGauge.java) that was accidentally unserializable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)