You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Siarhei_Yarkavy (JIRA)" <ji...@codehaus.org> on 2010/08/21 20:17:33 UTC
[jira] Created: (MWAR-235) The web.xml file included twice into the
result war
The web.xml file included twice into the result war
---------------------------------------------------
Key: MWAR-235
URL: http://jira.codehaus.org/browse/MWAR-235
Project: Maven 2.x WAR Plugin
Issue Type: Bug
Affects Versions: 2.1
Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
Reporter: Siarhei_Yarkavy
Priority: Critical
Attachments: asmModule.zip, screenshot.jpg
Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-235) The web.xml file included twice into
the result war
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=255390#action_255390 ]
Stephane Nicoll commented on MWAR-235:
--------------------------------------
Dennis, can you have a look to MWAR-248? It sounds like a possible regression due to this change.
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Assignee: Dennis Lundberg
> Priority: Critical
> Fix For: 2.1.1
>
> Attachments: asmModule.zip, MWAR-235-test.patch, pom.xml, screenshot.jpg, WarArchiver.java.patch
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-235) The web.xml file included twice into
the result war
Posted by "Bram (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=238372#action_238372 ]
Bram commented on MWAR-235:
---------------------------
Build with 092327-2.jar works fine for me. No more duplicate web.xml in the war.
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Assignee: Dennis Lundberg
> Priority: Critical
> Fix For: 2.2
>
> Attachments: asmModule.zip, MWAR-235-test.patch, pom.xml, screenshot.jpg, WarArchiver.java.patch
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-235) The web.xml file included twice into the
result war
Posted by "Michael Glauche (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Glauche updated MWAR-235:
---------------------------------
Attachment: WarArchiver.java.patch
WarArchiver.java.patch does fix this bug in the plexus-archiver war archiver.
First, the overwritten zipFile entry did not get called anymore, now has the same signature as the JarFile method. Second, the webInf warning seems incorrect, as it will be allways thrown. Now it does have a check if the webinf was added from the war plugin before.
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Priority: Critical
> Attachments: asmModule.zip, MWAR-235-test.patch, pom.xml, screenshot.jpg, WarArchiver.java.patch
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-235) The web.xml file included twice into
the result war
Posted by "Siarhei_Yarkavy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=232694#action_232694 ]
Siarhei_Yarkavy commented on MWAR-235:
--------------------------------------
I have forgotten to mention that is happened only when I specified web.xml location in plugin config
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Priority: Critical
> Attachments: asmModule.zip, screenshot.jpg
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-235) The web.xml file included twice into
the result war
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=238298#action_238298 ]
Dennis Lundberg commented on MWAR-235:
--------------------------------------
Fixed in [r1006261|http://svn.apache.org/viewvc?view=revision&revision=1006261].
Thanks to Michael Glauche for his patches.
A 2.2-SNAPSHOT has been deploy, please test it and report here how it works for you.
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Assignee: Dennis Lundberg
> Priority: Critical
> Fix For: 2.2
>
> Attachments: asmModule.zip, MWAR-235-test.patch, pom.xml, screenshot.jpg, WarArchiver.java.patch
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MWAR-235) The web.xml file included twice into the
result war
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg closed MWAR-235.
--------------------------------
Resolution: Fixed
Fix Version/s: 2.2
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Assignee: Dennis Lundberg
> Priority: Critical
> Fix For: 2.2
>
> Attachments: asmModule.zip, MWAR-235-test.patch, pom.xml, screenshot.jpg, WarArchiver.java.patch
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-235) The web.xml file included twice into
the result war
Posted by "Michael Glauche (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=233755#action_233755 ]
Michael Glauche commented on MWAR-235:
--------------------------------------
The problem seems that the WarArchiver is using
addFile( descr, "WEB-INF/web.xml" );
But later the WEB-INF lib does get added, too, so the web.xml is twice in the file-list.
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Priority: Critical
> Attachments: asmModule.zip, pom.xml, screenshot.jpg
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-235) The web.xml file included twice into
the result war
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=238367#action_238367 ]
Olivier Lamy commented on MWAR-235:
-----------------------------------
Try this one : https://repository.apache.org/content/groups/snapshots-group/
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Assignee: Dennis Lundberg
> Priority: Critical
> Fix For: 2.2
>
> Attachments: asmModule.zip, MWAR-235-test.patch, pom.xml, screenshot.jpg, WarArchiver.java.patch
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-235) The web.xml file included twice into the
result war
Posted by "Abhijit Sarkar (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abhijit Sarkar updated MWAR-235:
--------------------------------
Attachment: pom.xml
Hi, I am facing this same issue. It doesn't matter whether or not I specify the webXml parameter, the generated .war file contains 2 web.xml. I can confirm that war plugin v2.0.2 does not have this bug because it's working for me. Attached is my pom.xml.
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Priority: Critical
> Attachments: asmModule.zip, pom.xml, screenshot.jpg
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-235) The web.xml file included twice into
the result war
Posted by "Harald Lammers (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=237952#action_237952 ]
Harald Lammers commented on MWAR-235:
-------------------------------------
Workaround for the time being:
<configuration>
...
<packagingExcludes>**/web.xml</packagingExcludes>
...
</configuration>
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Priority: Critical
> Attachments: asmModule.zip, MWAR-235-test.patch, pom.xml, screenshot.jpg, WarArchiver.java.patch
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-235) The web.xml file included twice into
the result war
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=256955#action_256955 ]
Stephane Nicoll commented on MWAR-235:
--------------------------------------
Dennis, ping?
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Assignee: Dennis Lundberg
> Priority: Critical
> Fix For: 2.1.1
>
> Attachments: asmModule.zip, MWAR-235-test.patch, pom.xml, screenshot.jpg, WarArchiver.java.patch
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-235) The web.xml file included twice into
the result war
Posted by "Bram (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=238371#action_238371 ]
Bram commented on MWAR-235:
---------------------------
Hi, the last two builds do not have a jar. I'm trying to force my local mvn to just pick the 092327-2.jar but could the 142853-36.jar also be published? Tnx
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Assignee: Dennis Lundberg
> Priority: Critical
> Fix For: 2.2
>
> Attachments: asmModule.zip, MWAR-235-test.patch, pom.xml, screenshot.jpg, WarArchiver.java.patch
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-235) The web.xml file included twice into
the result war
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=238246#action_238246 ]
Olivier Lamy commented on MWAR-235:
-----------------------------------
plexus-archiver-1.2 has been released
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Assignee: Dennis Lundberg
> Priority: Critical
> Attachments: asmModule.zip, MWAR-235-test.patch, pom.xml, screenshot.jpg, WarArchiver.java.patch
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-235) The web.xml file included twice into
the result war
Posted by "Bram (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=238360#action_238360 ]
Bram commented on MWAR-235:
---------------------------
Uhm, which repo should I add to be able to download this?
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Assignee: Dennis Lundberg
> Priority: Critical
> Fix For: 2.2
>
> Attachments: asmModule.zip, MWAR-235-test.patch, pom.xml, screenshot.jpg, WarArchiver.java.patch
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-235) The web.xml file included twice into
the result war
Posted by "André Fügenschuh (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=233035#action_233035 ]
André Fügenschuh commented on MWAR-235:
---------------------------------------
Confirmed; signing the war generates an error:
{code}
[INFO] Failed executing 'cmd.exe /X /C "jarsigner.exe -keystore MyKeystore -storepass '*****' -keypass '*****' -storetype JCEKS -sigfile Foo /foo-1.4.0.war Foo"' - exitcode 1
[INFO] ------------------------------------------------------------------------
[INFO] Trace
org.apache.maven.lifecycle.LifecycleExecutionException: Failed executing 'cmd.exe /X /C "jarsigner.exe -keystore MyKeystore -storepass '*****' -keypass '*****' -storetype JCEKS -sigfile Foo /foo-1.4.0.war Foo"' - exitcode 1
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:719)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:556)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:535)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
at org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
Caused by: org.apache.maven.plugin.MojoExecutionException: Failed executing 'cmd.exe /X /C "jarsigner.exe -keystore MyKeystore -storepass '*****' -keypass '*****' -storetype JCEKS -sigfile Foo /foo-1.4.0.war Foo"' - exitcode 1
at org.apache.maven.plugins.jarsigner.AbstractJarsignerMojo.processArchive(AbstractJarsignerMojo.java:495)
at org.apache.maven.plugins.jarsigner.AbstractJarsignerMojo.processArtifact(AbstractJarsignerMojo.java:372)
at org.apache.maven.plugins.jarsigner.AbstractJarsignerMojo.execute(AbstractJarsignerMojo.java:197)
at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
... 17 more
{code}
Running the generated signing command (cmd.exe /X /C "jarsigner.exe ...) manually, the error is *similar*:
{code}
jarsigner: unable to sign jar: java.util.zip.ZipException: duplicate entry: WEB-INF/web.xml
{code}
on: Windows Vista SP2 x64, JDK 6u21, Maven 2.2.1
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Priority: Critical
> Attachments: asmModule.zip, screenshot.jpg
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-235) The web.xml file included twice into the
result war
Posted by "Michael Glauche (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Glauche updated MWAR-235:
---------------------------------
Attachment: MWAR-235-test.patch
Patch for the WarMojoTest to check duplicate files in a jar
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Priority: Critical
> Attachments: asmModule.zip, MWAR-235-test.patch, pom.xml, screenshot.jpg
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MWAR-235) The web.xml file included
twice into the result war
Posted by "Michael Glauche (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=233757#action_233757 ]
Michael Glauche edited comment on MWAR-235 at 8/31/10 6:50 AM:
---------------------------------------------------------------
Patch for the WarMojoTest to check duplicate files in a jar. Now the test does (correctly) fail like this:
{code}
junit.framework.AssertionFailedError: Duplicate Entry in Jar File: WEB-INF/web.xml
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.maven.plugin.war.WarMojoTest.assertJarContent(WarMojoTest.java:400)
at org.apache.maven.plugin.war.WarMojoTest.testSimpleWar(WarMojoTest.java:90)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at junit.framework.TestCase.runTest(TestCase.java:154)
at junit.framework.TestCase.runBare(TestCase.java:127)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:118)
{code}
was (Author: mglauche):
Patch for the WarMojoTest to check duplicate files in a jar
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Priority: Critical
> Attachments: asmModule.zip, MWAR-235-test.patch, pom.xml, screenshot.jpg
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-235) The web.xml file included twice into
the result war
Posted by "Noam Y. Tenne (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=233728#action_233728 ]
Noam Y. Tenne commented on MWAR-235:
------------------------------------
I can confirm this too. But it happens only in Windows. When built with Linux, it seems to be fine.
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Priority: Critical
> Attachments: asmModule.zip, pom.xml, screenshot.jpg
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-235) The web.xml file included twice into
the result war
Posted by "Michael Glauche (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=233747#action_233747 ]
Michael Glauche commented on MWAR-235:
--------------------------------------
Having the same problem, web.xml is getting added twice:
{code}
[DEBUG] Dump of the current build pathSet content -->
[DEBUG] index.html
[DEBUG] META-INF/MANIFEST.MF
[DEBUG] WEB-INF/faces-config.xml
[DEBUG] WEB-INF/jetty-env.xml
[DEBUG] WEB-INF/web.xml
[DEBUG] -- end of dump --
...
[INFO] Webapp assembled in [921 msecs]
[DEBUG] Excluding [] from the generated webapp archive.
[DEBUG] Including [**] in the generated webapp archive.
[INFO] Building war: C:\work\workspaces\project\project-web\target\project-web-0.2.0-SNAPSHOT.war
[DEBUG] adding directory META-INF/
[DEBUG] adding entry META-INF/MANIFEST.MF
[DEBUG] adding directory images/
[DEBUG] adding directory includes/
[DEBUG] adding directory pages/
[DEBUG] adding directory styles/
[DEBUG] adding directory WEB-INF/
[DEBUG] adding directory WEB-INF/classes/
...
[DEBUG] adding directory WEB-INF/lib/
[DEBUG] adding entry index.html
[DEBUG] adding entry WEB-INF/classes/application.properties
[DEBUG] adding entry WEB-INF/faces-config.xml
[DEBUG] adding entry WEB-INF/jetty-env.xml
[DEBUG] adding entry WEB-INF/lib/aopalliance-1.0.jar
[DEBUG] adding entry WEB-INF/lib/commons-fileupload-1.2.1.jar
... (many more libs)
[DEBUG] adding entry WEB-INF/web.xml
[DEBUG] adding entry WEB-INF/web.xml
[DEBUG] adding directory META-INF/maven/
...
{code}
Notice the two entries "adding web.xml" ...
Maven is 2.2.1, Maven-War Plugin is set to 2.1 (when unset, 2.1-alpha2 is used and everything works)
Java is 1.6.0_20 on win32.
The zip file does contain the same entry twice, in the same directory.
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Priority: Critical
> Attachments: asmModule.zip, pom.xml, screenshot.jpg
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-235) The web.xml file included twice into
the result war
Posted by "Bram (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=237644#action_237644 ]
Bram commented on MWAR-235:
---------------------------
Same problems here, when will the fix be released as a new Maven War plugin?
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Priority: Critical
> Attachments: asmModule.zip, MWAR-235-test.patch, pom.xml, screenshot.jpg, WarArchiver.java.patch
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-235) The web.xml file included twice into the
result war
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg updated MWAR-235:
---------------------------------
Fix Version/s: (was: 2.2)
2.1.1
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Assignee: Dennis Lundberg
> Priority: Critical
> Fix For: 2.1.1
>
> Attachments: asmModule.zip, MWAR-235-test.patch, pom.xml, screenshot.jpg, WarArchiver.java.patch
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MWAR-235) The web.xml file included
twice into the result war
Posted by "Siarhei_Yarkavy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=232694#action_232694 ]
Siarhei_Yarkavy edited comment on MWAR-235 at 8/21/10 1:29 PM:
---------------------------------------------------------------
I have forgotten to mention that is happened only when I specified web.xml location in plugin config
It seems plugin ver 2.1-beta-1 doesn't have this bug.
was (Author: neon.knight):
I have forgotten to mention that is happened only when I specified web.xml location in plugin config
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Priority: Critical
> Attachments: asmModule.zip, screenshot.jpg
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-235) The web.xml file included twice into
the result war
Posted by "Michael Glauche (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=256970#action_256970 ]
Michael Glauche commented on MWAR-235:
--------------------------------------
@Stephane: its more like an old undiscovered bug than a regression, the correct signature was not called, so the check was ignored in the old version. Now we need to see that the check is correct. If i can find some time i'll have a look on it.
> The web.xml file included twice into the result war
> ---------------------------------------------------
>
> Key: MWAR-235
> URL: http://jira.codehaus.org/browse/MWAR-235
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: WinXP 32bit sp3, sun JDK .6.0.20, maven 2.2.1
> Reporter: Siarhei_Yarkavy
> Assignee: Dennis Lundberg
> Priority: Critical
> Fix For: 2.1.1
>
> Attachments: asmModule.zip, MWAR-235-test.patch, pom.xml, screenshot.jpg, WarArchiver.java.patch
>
>
> Please have a look to the attached demo project and screen-shot
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira