You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "world970511 (via GitHub)" <gi...@apache.org> on 2026/10/05 12:07:57 UTC
[PR] [ZEPPELIN-5157] Fix stale Shiro authentication documentation links [zeppelin]
world970511 opened a new pull request, #5541:
URL: https://github.com/apache/zeppelin/pull/5541
…s spaces
### What is this PR for?
When Zeppelin initializes Shiro authentication, `shiroIniPath` already contains the actual filesystem path to `shiro.ini`.
Previously, the path was converted using `new File(...).toURI()`. This URI conversion percent-encodes special characters in the filesystem path. For example, a path containing a space such as:
`/opt/my zeppelin/conf/shiro.ini`
is converted to:
`/opt/my%20zeppelin/conf/shiro.ini`
As a result, Shiro may fail to locate the actual configuration file when the Zeppelin installation path contains spaces or other characters that are encoded during URI conversion.
This PR removes the unnecessary `toURI()` conversion and constructs the Shiro configuration location by prefixing the original filesystem path with `file:`.
This preserves the filesystem path as-is and prevents unintended percent encoding.
### What type of PR is it?
Bug Fix
### Todos
* [x] Remove unnecessary URI conversion for the Shiro configuration path
* [x] Preserve the original filesystem path when constructing the `file:` location
* [x] Verify behavior with a Zeppelin path containing spaces
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5157
### How should this be tested?
The issue can be reproduced by running Zeppelin from a directory whose path contains spaces.
For example:
`/opt/my zeppelin/`
1. Configure Zeppelin to use Shiro authentication.
2. Place `shiro.ini` under the Zeppelin configuration directory.
3. Start Zeppelin from an installation path containing spaces.
4. Verify that the Shiro configuration file is loaded successfully.
Before this change, the filesystem path could be converted to a percent-encoded URI path such as `%20`, causing Shiro to fail to locate the configuration file.
After this change, the original filesystem path is passed to Shiro without URI percent encoding.
### Screenshots (if appropriate)
N/A
### Questions:
* Does the license files need to update? No.
* Is there breaking changes for older versions? No.
* Does this needs documentation? No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-5157] Fix stale Shiro authentication documentation links [zeppelin]
Posted by "world970511 (via GitHub)" <gi...@apache.org>.
world970511 closed pull request #5541: [ZEPPELIN-5157] Fix stale Shiro authentication documentation links
URL: https://github.com/apache/zeppelin/pull/5541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org