You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/21 20:41:32 UTC

[GitHub] [tvm] driazati commented on a diff in pull request #11045: [docs] Add lightweight docs image

driazati commented on code in PR #11045:
URL: https://github.com/apache/tvm/pull/11045#discussion_r855576983


##########
tests/scripts/ci.py:
##########
@@ -239,20 +231,20 @@ def docs(
     skip_build -- skip build and setup scripts
     interactive -- start a shell after running build / test scripts
     """
-    config = "./tests/scripts/task_config_build_gpu.sh"
     build_dir = get_build_dir("gpu")
     if cpu and full:

Review Comment:
   not necessarily since tutorials don’t always require the GPU, though it’s probably usually used they way you mention, i’d prefer keeping it closer to what’s actually going on so it’s more clear how the tool works



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org